You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by "jpeach (via GitHub)" <gi...@apache.org> on 2023/07/04 04:39:53 UTC

[GitHub] [trafficserver] jpeach commented on a diff in pull request #9943: Add yaml libs reference to HTTP proxy test suite.

jpeach commented on code in PR #9943:
URL: https://github.com/apache/trafficserver/pull/9943#discussion_r1251471190


##########
proxy/http/Makefile.am:
##########
@@ -158,7 +160,8 @@ test_HttpTransact_LDADD = \
 	@LIBZ@ \
 	@LIBLZMA@ \
 	@OPENSSL_LIBS@ \
-	-lm
+	-lm \
+	@YAMLCPP_LIBS@

Review Comment:
   ```suggestion
    	@YAMLCPP_LIBS@ \
   	-lm
   ```
   
   BEst of keep `-lm` last since order matters :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org