You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2017/04/04 22:23:52 UTC

Review Request 58193: Renamed variables in checker library for clarity.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58193/
-----------------------------------------------------------

Review request for mesos, Gast�n Kleiman and Vinod Kone.


Repository: mesos


Description
-------

See summary.


Diffs
-----

  src/checks/checker.cpp 7510bf23977e007d101fab635865b7160c3a5af6 


Diff: https://reviews.apache.org/r/58193/diff/1/


Testing
-------

See https://reviews.apache.org/r/58196/


Thanks,

Alexander Rukletsov


Re: Review Request 58193: Renamed variables in checker library for clarity.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58193/#review171297
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On April 4, 2017, 10:23 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58193/
> -----------------------------------------------------------
> 
> (Updated April 4, 2017, 10:23 p.m.)
> 
> 
> Review request for mesos, Gast�n Kleiman and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/checks/checker.cpp 7510bf23977e007d101fab635865b7160c3a5af6 
> 
> 
> Diff: https://reviews.apache.org/r/58193/diff/1/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/58196/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Re: Review Request 58193: Renamed variables in checker library for clarity.

Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58193/#review171329
-----------------------------------------------------------


Ship it!




Ship It!

- Gast�n Kleiman


On April 4, 2017, 10:23 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58193/
> -----------------------------------------------------------
> 
> (Updated April 4, 2017, 10:23 p.m.)
> 
> 
> Review request for mesos, Gast�n Kleiman and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/checks/checker.cpp 7510bf23977e007d101fab635865b7160c3a5af6 
> 
> 
> Diff: https://reviews.apache.org/r/58193/diff/1/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/58196/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Re: Review Request 58193: Renamed variables in checker library for clarity.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58193/
-----------------------------------------------------------

(Updated April 19, 2017, 3:15 p.m.)


Review request for mesos, Gast�n Kleiman and Vinod Kone.


Changes
-------

Rebased. NNTR.


Repository: mesos


Description
-------

See summary.


Diffs (updated)
-----

  src/checks/checker.cpp cf7a086ead4413083ea1e28112f1f22dc18f0a89 


Diff: https://reviews.apache.org/r/58193/diff/2/

Changes: https://reviews.apache.org/r/58193/diff/1-2/


Testing
-------

See https://reviews.apache.org/r/58196/


Thanks,

Alexander Rukletsov