You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "scottsignal (via GitHub)" <gi...@apache.org> on 2025/02/13 22:13:30 UTC
[I] Domain - "View Templates" Button Does Not Filter [cloudstack]
scottsignal opened a new issue, #10392:
URL: https://github.com/apache/cloudstack/issues/10392
### problem
Clicking on View Templates from Domain as Root Admin does not filter correctly.
Expecting to only see 2 templates:
### versions
4.19.1.3 & 4.20.0.0
GUI
KVM
### The steps to reproduce the bug
1. Logged in as Root Admin click on Domains
2. Choose a Sub-Domain (Note: this Sub-Domain should have its own templates)
3. Click on the View Templates Button
4. Observe the returned results are not for just that domain. There is no filtering done.
### What to do about it?
While this is similar to #10391, I'm not sure on this one. ListTemplates seems to require an Account Name (Unless this is actually a bug as well). Simply adding `&templatefilter=self` does not fix this.
If ListTemplates really requires an account name, is this button needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Domain - "View Templates" Button Does Not Filter [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland closed issue #10392: Domain - "View Templates" Button Does Not Filter
URL: https://github.com/apache/cloudstack/issues/10392
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Domain - "View Templates" Button Does Not Filter [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on issue #10392:
URL: https://github.com/apache/cloudstack/issues/10392#issuecomment-2658688930
@bernardodemarco , did you execute the API as the account in `ROOT/d1` ? As root admin I would expect all templates to be returned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Domain - "View Templates" Button Does Not Filter [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on issue #10392:
URL: https://github.com/apache/cloudstack/issues/10392#issuecomment-2858624962
fixed by #10425
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Domain - "View Templates" Button Does Not Filter [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on issue #10392:
URL: https://github.com/apache/cloudstack/issues/10392#issuecomment-3082907478
fixed in #11179
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Domain - "View Templates" Button Does Not Filter [cloudstack]
Posted by "bernardodemarco (via GitHub)" <gi...@apache.org>.
bernardodemarco commented on issue #10392:
URL: https://github.com/apache/cloudstack/issues/10392#issuecomment-2657968126
@scottsignal, thanks for reporting the bug, I reproduced it in 4.19.
> Simply adding &templatefilter=self does not fix this.
Yes, it seems to be an API bug. In my local environment, I created a domain `ROOT/d1` and registered a template with an account belonging to that domain. However, when executing the `listTemplates` API through CloudMonkey, specifying the `ROOT/d1` ID in the `domainid` field, all templates are returned:
```bash
(localcloud) 🐂 > list templates templatefilter=self domainid=e4484046-403c-41df-80ac-c21f760edaec filter=name,account,domain
{
"count": 6,
"template": [
{
"account": "admin",
"domain": "ROOT",
"name": "systemvm-kvm-4.19.1"
},
{
"account": "admin",
"domain": "ROOT",
"name": "systemvm-kvm-4.20.0-x86_64"
},
{
"account": "admin",
"domain": "ROOT",
"name": "Ubuntu 18.04"
},
{
"account": "d1",
"domain": "d1",
"name": "Macchinina"
},
{
"account": "system",
"domain": "ROOT",
"name": "SystemVM Template (KVM)"
},
{
"account": "system",
"domain": "ROOT",
"name": "CentOS 5.5(64-bit) no GUI (KVM)"
}
]
}
```
---
> If ListTemplates really requires an account name, is this button needed?
I'm not entirely sure if the `account` field is required. If it were, the API docs, or the API response, would need to somehow inform it to the users. Therefore, it needs further investigation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Domain - "View Templates" Button Does Not Filter [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on issue #10392:
URL: https://github.com/apache/cloudstack/issues/10392#issuecomment-2660934385
@bernardodemarco , I agree that filtering to suit the user should be possible auth permitting. I feared for a moment that we had a problem with authorisation, but root admin has god rights ;) . I do urge that the default remains the present show all behaviour. however, the redirection from the domains page may of course set a filter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Domain - "View Templates" Button Does Not Filter [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on issue #10392:
URL: https://github.com/apache/cloudstack/issues/10392#issuecomment-3049846358
thanks for the heads-up @scottsignal . reopened it.
I think actually it is fixed in 4.21 to be by #10488. Can you check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Domain - "View Templates" Button Does Not Filter [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland closed issue #10392: Domain - "View Templates" Button Does Not Filter
URL: https://github.com/apache/cloudstack/issues/10392
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Domain - "View Templates" Button Does Not Filter [cloudstack]
Posted by "bernardodemarco (via GitHub)" <gi...@apache.org>.
bernardodemarco commented on issue #10392:
URL: https://github.com/apache/cloudstack/issues/10392#issuecomment-2659604024
> @bernardodemarco , did you execute the API as the account in ROOT/d1 ?
No, I executed it with a Root Admin account.
> As root admin I would expect all templates to be returned.
Yes, I agree that Root Admins expect all templates to be returned. However, I also think that Root Admins should have the ability to filter templates by domain and account. The filtering by account currently is already achieved through the API; the UI does not support it (vide #10391). The filtering by domain is not supported neither through the UI, nor through the API (vide https://github.com/apache/cloudstack/issues/10392#issuecomment-2657968126).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Domain - "View Templates" Button Does Not Filter [cloudstack]
Posted by "scottsignal (via GitHub)" <gi...@apache.org>.
scottsignal commented on issue #10392:
URL: https://github.com/apache/cloudstack/issues/10392#issuecomment-2675850583
> [@bernardodemarco](https://github.com/bernardodemarco) , I agree that filtering to suit the user should be possible auth permitting. I feared for a moment that we had a problem with authorisation, but root admin has god rights ;) . I do urge that the default remains the present show all behaviour. however, the redirection from the domains page may of course set a filter.
Just wanted to add, I fully expect that template view should remain the same. As a Root Admin you should see everything by default with no filtering. I did want to point out maybe there is an opportunity to add some filtering options to the Template View. More than happy to open this as an enhancment for down the road.
IE: All the other views (Instances / Storage / ETC) however its missing from Templates/ISO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Domain - "View Templates" Button Does Not Filter [cloudstack]
Posted by "bernardodemarco (via GitHub)" <gi...@apache.org>.
bernardodemarco commented on issue #10392:
URL: https://github.com/apache/cloudstack/issues/10392#issuecomment-3049998549
Hello, @scottsignal and @DaanHoogland
PR #10425 was targeted for version 4.19.3 and aimed to fix the filtering of templates by account.
PR #10488, on the other hand, introduced a UI option to filter ISOs by account.
The current issue involves listing templates by domain. However, I’ve recently been prioritizing the implementation of other functionalities. I’ll try to address this ASAP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Domain - "View Templates" Button Does Not Filter [cloudstack]
Posted by "scottsignal (via GitHub)" <gi...@apache.org>.
scottsignal commented on issue #10392:
URL: https://github.com/apache/cloudstack/issues/10392#issuecomment-3049825755
@DaanHoogland , I don't think this was fixed by [#10425](https://github.com/apache/cloudstack/pull/10425). This PR was for Account Details. This fixed issue [#10391](https://github.com/apache/cloudstack/issues/10391)
I can still reproduce this under 4.19.3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org