You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by GitBox <gi...@apache.org> on 2020/09/30 20:05:12 UTC

[GitHub] [groovy] muse-dev[bot] commented on a change in pull request #1384: add missing @Override annotations

muse-dev[bot] commented on a change in pull request #1384:
URL: https://github.com/apache/groovy/pull/1384#discussion_r497768542



##########
File path: subprojects/groovy-json/src/main/java/org/apache/groovy/json/internal/ValueContainer.java
##########
@@ -62,14 +62,17 @@ public ValueContainer(List<Object> list) {
         this.container = true;
     }
 
+    @Override
     public int intValue() {
         return die(int.class, sputs("intValue not supported for type ", type));
     }
 
+    @Override
     public long longValue() {
         return die(int.class, sputs("intValue not supported for type ", type));
     }
 
+    @Override
     public boolean booleanValue() {
         switch (type) {

Review comment:
       *MissingCasesInEnumSwitch:*  Non-exhaustive switch; either add a default or handle the remaining cases: INTEGER, STRING, DOUBLE, and 3 others




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org