You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Stephan Erb <se...@apache.org> on 2018/05/25 14:58:52 UTC
Review Request 67326: Update Pants to 1.6.0 and Virtualenv to 16.2.0
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67326/
-----------------------------------------------------------
Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
Repository: aurora
Description
-------
Beyond a regular version bump, this fixes the build on older versions of MacOS.
Diffs
-----
build-support/jenkins/build.sh a5975398929d01268841fa4c02aa360b309f6114
build-support/python/checkstyle-check 7e65dd97687d3bd5b586cec163f973d08decab6e
build-support/thrift/thriftw 26b4f9c8087214222100a46d83b47dbce01a7471
build-support/virtualenv d6484f58fbffd33ef61d6052c869c55153ec7313
pants 312dd2035a5ad2e65a1fb3f52d1c36693c2624f0
pants.ini 8c71b144619f437175727dd2027f702ee749df11
rbt 7531fcb2ed21d125bbd2adf5611db82a1a727545
src/main/python/apache/aurora/executor/BUILD 486230db34a22ea5dd0f68da911c0afb1afbcac0
Diff: https://reviews.apache.org/r/67326/diff/1/
Testing
-------
./build-support/jenkins/build.sh
Thanks,
Stephan Erb
Re: Review Request 67326: Update Pants to 1.6.0 and Virtualenv to
16.2.0
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67326/#review203888
-----------------------------------------------------------
Master (34be631) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On May 25, 2018, 7:58 a.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67326/
> -----------------------------------------------------------
>
> (Updated May 25, 2018, 7:58 a.m.)
>
>
> Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Beyond a regular version bump, this fixes the build on older versions of MacOS.
>
>
> Diffs
> -----
>
> build-support/jenkins/build.sh a5975398929d01268841fa4c02aa360b309f6114
> build-support/python/checkstyle-check 7e65dd97687d3bd5b586cec163f973d08decab6e
> build-support/thrift/thriftw 26b4f9c8087214222100a46d83b47dbce01a7471
> build-support/virtualenv d6484f58fbffd33ef61d6052c869c55153ec7313
> pants 312dd2035a5ad2e65a1fb3f52d1c36693c2624f0
> pants.ini 8c71b144619f437175727dd2027f702ee749df11
> rbt 7531fcb2ed21d125bbd2adf5611db82a1a727545
> src/main/python/apache/aurora/executor/BUILD 486230db34a22ea5dd0f68da911c0afb1afbcac0
>
>
> Diff: https://reviews.apache.org/r/67326/diff/1/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 67326: Update Pants to 1.6.0 and Virtualenv to
16.2.0
Posted by se choi <th...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67326/#review203942
-----------------------------------------------------------
Ship it!
Ship It!
- se choi
On May 25, 2018, 11:58 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67326/
> -----------------------------------------------------------
>
> (Updated May 25, 2018, 11:58 p.m.)
>
>
> Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Beyond a regular version bump, this fixes the build on older versions of MacOS.
>
>
> Diffs
> -----
>
> build-support/jenkins/build.sh a5975398929d01268841fa4c02aa360b309f6114
> build-support/python/checkstyle-check 7e65dd97687d3bd5b586cec163f973d08decab6e
> build-support/thrift/thriftw 26b4f9c8087214222100a46d83b47dbce01a7471
> build-support/virtualenv d6484f58fbffd33ef61d6052c869c55153ec7313
> pants 312dd2035a5ad2e65a1fb3f52d1c36693c2624f0
> pants.ini 8c71b144619f437175727dd2027f702ee749df11
> rbt 7531fcb2ed21d125bbd2adf5611db82a1a727545
> src/main/python/apache/aurora/executor/BUILD 486230db34a22ea5dd0f68da911c0afb1afbcac0
>
>
> Diff: https://reviews.apache.org/r/67326/diff/1/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 67326: Update Pants to 1.6.0 and Virtualenv to
16.2.0
Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.
> On June 13, 2018, 12:19 p.m., Santhosh Kumar Shanmugham wrote:
> > Ship It!
Actullay minor comment - fix the commit message "Virutalenv version is mis-spelled"
- Santhosh Kumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67326/#review204723
-----------------------------------------------------------
On May 25, 2018, 7:58 a.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67326/
> -----------------------------------------------------------
>
> (Updated May 25, 2018, 7:58 a.m.)
>
>
> Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Beyond a regular version bump, this fixes the build on older versions of MacOS.
>
>
> Diffs
> -----
>
> build-support/jenkins/build.sh a5975398929d01268841fa4c02aa360b309f6114
> build-support/python/checkstyle-check 7e65dd97687d3bd5b586cec163f973d08decab6e
> build-support/thrift/thriftw 26b4f9c8087214222100a46d83b47dbce01a7471
> build-support/virtualenv d6484f58fbffd33ef61d6052c869c55153ec7313
> pants 312dd2035a5ad2e65a1fb3f52d1c36693c2624f0
> pants.ini 8c71b144619f437175727dd2027f702ee749df11
> rbt 7531fcb2ed21d125bbd2adf5611db82a1a727545
> src/main/python/apache/aurora/executor/BUILD 486230db34a22ea5dd0f68da911c0afb1afbcac0
>
>
> Diff: https://reviews.apache.org/r/67326/diff/1/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 67326: Update Pants to 1.6.0 and Virtualenv to
16.0.0
Posted by Stephan Erb <se...@apache.org>.
> On June 13, 2018, 9:19 p.m., Santhosh Kumar Shanmugham wrote:
> > Ship It!
>
> Santhosh Kumar Shanmugham wrote:
> Actullay minor comment - fix the commit message "Virutalenv version is mis-spelled"
Oh good catch, thanks!
- Stephan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67326/#review204723
-----------------------------------------------------------
On June 13, 2018, 9:41 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67326/
> -----------------------------------------------------------
>
> (Updated June 13, 2018, 9:41 p.m.)
>
>
> Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Beyond a regular version bump, this fixes the build on older versions of MacOS.
>
>
> Diffs
> -----
>
> build-support/jenkins/build.sh a5975398929d01268841fa4c02aa360b309f6114
> build-support/python/checkstyle-check 7e65dd97687d3bd5b586cec163f973d08decab6e
> build-support/thrift/thriftw 26b4f9c8087214222100a46d83b47dbce01a7471
> build-support/virtualenv d6484f58fbffd33ef61d6052c869c55153ec7313
> pants 312dd2035a5ad2e65a1fb3f52d1c36693c2624f0
> pants.ini 8c71b144619f437175727dd2027f702ee749df11
> rbt 7531fcb2ed21d125bbd2adf5611db82a1a727545
> src/main/python/apache/aurora/executor/BUILD 486230db34a22ea5dd0f68da911c0afb1afbcac0
>
>
> Diff: https://reviews.apache.org/r/67326/diff/1/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 67326: Update Pants to 1.6.0 and Virtualenv to
16.2.0
Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67326/#review204723
-----------------------------------------------------------
Ship it!
Ship It!
- Santhosh Kumar Shanmugham
On May 25, 2018, 7:58 a.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67326/
> -----------------------------------------------------------
>
> (Updated May 25, 2018, 7:58 a.m.)
>
>
> Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Beyond a regular version bump, this fixes the build on older versions of MacOS.
>
>
> Diffs
> -----
>
> build-support/jenkins/build.sh a5975398929d01268841fa4c02aa360b309f6114
> build-support/python/checkstyle-check 7e65dd97687d3bd5b586cec163f973d08decab6e
> build-support/thrift/thriftw 26b4f9c8087214222100a46d83b47dbce01a7471
> build-support/virtualenv d6484f58fbffd33ef61d6052c869c55153ec7313
> pants 312dd2035a5ad2e65a1fb3f52d1c36693c2624f0
> pants.ini 8c71b144619f437175727dd2027f702ee749df11
> rbt 7531fcb2ed21d125bbd2adf5611db82a1a727545
> src/main/python/apache/aurora/executor/BUILD 486230db34a22ea5dd0f68da911c0afb1afbcac0
>
>
> Diff: https://reviews.apache.org/r/67326/diff/1/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 67326: Update Pants to 1.6.0 and Virtualenv to
16.0.0
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67326/
-----------------------------------------------------------
(Updated June 13, 2018, 9:41 p.m.)
Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
Summary (updated)
-----------------
Update Pants to 1.6.0 and Virtualenv to 16.0.0
Repository: aurora
Description
-------
Beyond a regular version bump, this fixes the build on older versions of MacOS.
Diffs
-----
build-support/jenkins/build.sh a5975398929d01268841fa4c02aa360b309f6114
build-support/python/checkstyle-check 7e65dd97687d3bd5b586cec163f973d08decab6e
build-support/thrift/thriftw 26b4f9c8087214222100a46d83b47dbce01a7471
build-support/virtualenv d6484f58fbffd33ef61d6052c869c55153ec7313
pants 312dd2035a5ad2e65a1fb3f52d1c36693c2624f0
pants.ini 8c71b144619f437175727dd2027f702ee749df11
rbt 7531fcb2ed21d125bbd2adf5611db82a1a727545
src/main/python/apache/aurora/executor/BUILD 486230db34a22ea5dd0f68da911c0afb1afbcac0
Diff: https://reviews.apache.org/r/67326/diff/1/
Testing
-------
./build-support/jenkins/build.sh
Thanks,
Stephan Erb
Re: Review Request 67326: Update Pants to 1.6.0 and Virtualenv to
16.2.0
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67326/#review204633
-----------------------------------------------------------
Friendly ping :)
- Stephan Erb
On May 25, 2018, 4:58 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67326/
> -----------------------------------------------------------
>
> (Updated May 25, 2018, 4:58 p.m.)
>
>
> Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Beyond a regular version bump, this fixes the build on older versions of MacOS.
>
>
> Diffs
> -----
>
> build-support/jenkins/build.sh a5975398929d01268841fa4c02aa360b309f6114
> build-support/python/checkstyle-check 7e65dd97687d3bd5b586cec163f973d08decab6e
> build-support/thrift/thriftw 26b4f9c8087214222100a46d83b47dbce01a7471
> build-support/virtualenv d6484f58fbffd33ef61d6052c869c55153ec7313
> pants 312dd2035a5ad2e65a1fb3f52d1c36693c2624f0
> pants.ini 8c71b144619f437175727dd2027f702ee749df11
> rbt 7531fcb2ed21d125bbd2adf5611db82a1a727545
> src/main/python/apache/aurora/executor/BUILD 486230db34a22ea5dd0f68da911c0afb1afbcac0
>
>
> Diff: https://reviews.apache.org/r/67326/diff/1/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
>
>
> Thanks,
>
> Stephan Erb
>
>