You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2019/12/19 03:12:35 UTC
[GitHub] [rocketmq-spring] SvenAugustus opened a new pull request #205:
[ISSUE #88] Consumer Batch API #170
SvenAugustus opened a new pull request #205: [ISSUE #88] Consumer Batch API #170
URL: https://github.com/apache/rocketmq-spring/pull/205
## What is the purpose of the change
Provides a new Consumer Batch API, instead of extending `RocketMQListener`.
## Brief changelog
- add `RocketMQBatchListener` , subinterface of `RocketMQListener`.
- update `ListenerContainerConfiguration` to support `RocketMQBatchListener` by adding annotation `@RocketMQMessageListener` .
- update `DefaultRocketMQListenerContainer` consume messages functions:
If field `rocketMQListener` is instacne of `RocketMQBatchListener` , then prior to execute batch api `RocketMQBatchListener#onMessages` insteading of `RocketMQListener#onMessage`.
Or defaults.
## Verifying this change
Unit Test is shown in `DefaultRocketMQListenerContainerTest#testBatchGetMessages` .
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist.
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-spring] SvenAugustus commented on issue #205: [ISSUE #88]
Consumer Batch API
Posted by GitBox <gi...@apache.org>.
SvenAugustus commented on issue #205: [ISSUE #88] Consumer Batch API
URL: https://github.com/apache/rocketmq-spring/pull/205#issuecomment-569071269
@vongosling Little doubt. The local batch functionality of RocketMQ as your said is using `MessageExtBatch` instead of `List<MessageExt>` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-spring] RongtongJin closed pull request #205: [ISSUE #88]
Consumer Batch API
Posted by GitBox <gi...@apache.org>.
RongtongJin closed pull request #205: [ISSUE #88] Consumer Batch API
URL: https://github.com/apache/rocketmq-spring/pull/205
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-spring] RongtongJin commented on issue #205: [ISSUE #88]
Consumer Batch API
Posted by GitBox <gi...@apache.org>.
RongtongJin commented on issue #205: [ISSUE #88] Consumer Batch API
URL: https://github.com/apache/rocketmq-spring/pull/205#issuecomment-568849183
I will temporarily close this PR. If you want do more work as @ vongosling said, we can discuss in this thread.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-spring] vongosling commented on issue #205: [ISSUE #88]
Consumer Batch API
Posted by GitBox <gi...@apache.org>.
vongosling commented on issue #205: [ISSUE #88] Consumer Batch API
URL: https://github.com/apache/rocketmq-spring/pull/205#issuecomment-568830732
I don't think this pr can meet the needs of batching consumers. There is a proposal to add some local batch functionality to RocketMQ. I suggest that we take advantage of this native capability and combine it with the implementation of spring for optimization. Welcome to follow up on the resolution of this issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services