You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by StefanRRichter <gi...@git.apache.org> on 2016/09/19 15:57:06 UTC
[GitHub] flink pull request #2513: [hotfix] RescalingITCase
GitHub user StefanRRichter opened a pull request:
https://github.com/apache/flink/pull/2513
[hotfix] RescalingITCase
Hotfix for RescalingITCase: race condition could make the test stuck in a blocking call until timeout.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/StefanRRichter/flink hotfix-rescalingitcase
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2513.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2513
----
commit 128332565e07fb140bb91825d14999b7837da326
Author: Stefan Richter <s....@data-artisans.com>
Date: 2016-09-19T15:54:23Z
[hotfix] RescalingITCase: race condition could make the test stuck in a blocking call until timeout
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2513: [hotfix] RescalingITCase
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2513#discussion_r79466613
--- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/RescalingITCase.java ---
@@ -670,12 +676,15 @@ public void run(SourceContext<Integer> ctx) throws Exception {
}
Thread.sleep(100);
--- End diff --
This seems like a long wait time actually (100ms). How about waiting 2ms and signaling after the 10th element.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2513: [hotfix] RescalingITCase
Posted by StefanRRichter <gi...@git.apache.org>.
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/2513#discussion_r79470571
--- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/RescalingITCase.java ---
@@ -670,12 +676,15 @@ public void run(SourceContext<Integer> ctx) throws Exception {
}
Thread.sleep(100);
--- End diff --
I just kept the the original value from @tillrohrmann to minimize unrelated changes. I assume the concrete choice of 100ms is arbitrary so I am fine with the proposed change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2513: [hotfix] RescalingITCase
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2513#discussion_r79598970
--- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/RescalingITCase.java ---
@@ -670,12 +676,15 @@ public void run(SourceContext<Integer> ctx) throws Exception {
}
Thread.sleep(100);
--- End diff --
You only have to make sure that the sources have not finished their processing when a savepoint is taken from them. But you can assure that differently by waiting on a future which is completed when the source has processed all a certain amount of elements.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2513: [hotfix] RescalingITCase
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2513
Looks good to me, merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2513: [hotfix] RescalingITCase
Posted by StefanRRichter <gi...@git.apache.org>.
Github user StefanRRichter closed the pull request at:
https://github.com/apache/flink/pull/2513
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---