You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/25 19:35:28 UTC
[GitHub] [arrow-datafusion] edrevo opened a new pull request #75: Remove namespace from executors
edrevo opened a new pull request #75:
URL: https://github.com/apache/arrow-datafusion/pull/75
# Which issue does this PR close?
Closes #66.
# Are there any user-facing changes?
Yes. The `namespace` CLI option in the ballista executors disappear. This is actually good, since the description of that param was not in sync with the implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on pull request #75: Remove namespace from executors
Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #75:
URL: https://github.com/apache/arrow-datafusion/pull/75#issuecomment-827600923
@edrevo Please rebase and we can merge this one. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on a change in pull request #75: Remove namespace from executors
Posted by GitBox <gi...@apache.org>.
andygrove commented on a change in pull request #75:
URL: https://github.com/apache/arrow-datafusion/pull/75#discussion_r621200597
##########
File path: ballista/rust/executor/src/main.rs
##########
@@ -109,8 +108,10 @@ async fn main() -> Result<()> {
info!("Running in local mode. Scheduler will be run in-proc");
let client = StandaloneClient::try_new_temporary()
.context("Could not create standalone config backend")?;
- let server =
- SchedulerGrpcServer::new(SchedulerServer::new(Arc::new(client), namespace));
+ let server = SchedulerGrpcServer::new(SchedulerServer::new(
+ Arc::new(client),
+ "ballista".to_string(),
Review comment:
I checked the code out locally and see that this is where we are running in local mode. Makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] edrevo commented on pull request #75: Remove namespace from executors
Posted by GitBox <gi...@apache.org>.
edrevo commented on pull request #75:
URL: https://github.com/apache/arrow-datafusion/pull/75#issuecomment-827841991
done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #75: Remove namespace from executors
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #75:
URL: https://github.com/apache/arrow-datafusion/pull/75#issuecomment-826379778
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/75?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#75](https://codecov.io/gh/apache/arrow-datafusion/pull/75?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33dfcc3) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/35bc3d7edb51bbc0e98e911d0b3a6fa1abf0d4cf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (35bc3d7) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/arrow-datafusion/pull/75?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #75 +/- ##
=======================================
Coverage 76.35% 76.36%
=======================================
Files 134 134
Lines 23018 23017 -1
=======================================
Hits 17576 17576
+ Misses 5442 5441 -1
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-datafusion/pull/75?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [ballista/rust/executor/src/main.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/75/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmFsbGlzdGEvcnVzdC9leGVjdXRvci9zcmMvbWFpbi5ycw==) | `0.00% <ø> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/75?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/75?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [35bc3d7...33dfcc3](https://codecov.io/gh/apache/arrow-datafusion/pull/75?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on a change in pull request #75: Remove namespace from executors
Posted by GitBox <gi...@apache.org>.
andygrove commented on a change in pull request #75:
URL: https://github.com/apache/arrow-datafusion/pull/75#discussion_r620849175
##########
File path: ballista/rust/executor/src/main.rs
##########
@@ -109,8 +108,10 @@ async fn main() -> Result<()> {
info!("Running in local mode. Scheduler will be run in-proc");
let client = StandaloneClient::try_new_temporary()
.context("Could not create standalone config backend")?;
- let server =
- SchedulerGrpcServer::new(SchedulerServer::new(Arc::new(client), namespace));
+ let server = SchedulerGrpcServer::new(SchedulerServer::new(
+ Arc::new(client),
+ "ballista".to_string(),
Review comment:
Why do we still need to provide the namespace here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove merged pull request #75: Remove namespace from executors
Posted by GitBox <gi...@apache.org>.
andygrove merged pull request #75:
URL: https://github.com/apache/arrow-datafusion/pull/75
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #75: Remove namespace from executors
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #75:
URL: https://github.com/apache/arrow-datafusion/pull/75#issuecomment-826379778
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/75?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#75](https://codecov.io/gh/apache/arrow-datafusion/pull/75?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33dfcc3) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/35bc3d7edb51bbc0e98e911d0b3a6fa1abf0d4cf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (35bc3d7) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/arrow-datafusion/pull/75?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #75 +/- ##
=======================================
Coverage 76.35% 76.36%
=======================================
Files 134 134
Lines 23018 23017 -1
=======================================
Hits 17576 17576
+ Misses 5442 5441 -1
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-datafusion/pull/75?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [ballista/rust/executor/src/main.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/75/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmFsbGlzdGEvcnVzdC9leGVjdXRvci9zcmMvbWFpbi5ycw==) | `0.00% <ø> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/75?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/75?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [35bc3d7...33dfcc3](https://codecov.io/gh/apache/arrow-datafusion/pull/75?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org