You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/03/11 19:52:02 UTC
[GitHub] [mynewt-nimble] rymanluk opened a new pull request #769:
nimble/host: Couple of fixes to l2cap coc
rymanluk opened a new pull request #769: nimble/host: Couple of fixes to l2cap coc
URL: https://github.com/apache/mynewt-nimble/pull/769
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #769:
nimble/host: Couple of fixes to l2cap coc
Posted by GitBox <gi...@apache.org>.
sjanc commented on a change in pull request #769: nimble/host: Couple of fixes to l2cap coc
URL: https://github.com/apache/mynewt-nimble/pull/769#discussion_r391502832
##########
File path: nimble/host/src/ble_l2cap_sig.c
##########
@@ -744,7 +744,6 @@ ble_l2cap_sig_credit_base_reconfig_req_rx(uint16_t conn_handle,
* remote will timeout.
*/
BLE_HS_LOG(ERROR, "No memory for the response\n");
- ble_hs_unlock();
Review comment:
?? this will leave lock locked
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-nimble] rymanluk commented on a change in pull request
#769: nimble/host: Couple of fixes to l2cap coc
Posted by GitBox <gi...@apache.org>.
rymanluk commented on a change in pull request #769: nimble/host: Couple of fixes to l2cap coc
URL: https://github.com/apache/mynewt-nimble/pull/769#discussion_r391506782
##########
File path: nimble/host/src/ble_l2cap_sig.c
##########
@@ -744,7 +744,6 @@ ble_l2cap_sig_credit_base_reconfig_req_rx(uint16_t conn_handle,
* remote will timeout.
*/
BLE_HS_LOG(ERROR, "No memory for the response\n");
- ble_hs_unlock();
Review comment:
ups, thx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-nimble] rymanluk merged pull request #769: nimble/host:
Couple of fixes to l2cap coc
Posted by GitBox <gi...@apache.org>.
rymanluk merged pull request #769: nimble/host: Couple of fixes to l2cap coc
URL: https://github.com/apache/mynewt-nimble/pull/769
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services