[GitHub] [arrow-datafusion] matthewmturner commented on a change in pull request #2076: Remove dependency of common for the storage crate

[GitBox <gi...@apache.org>]

matthewmturner commented on a change in pull request #2076:
URL: https://github.com/apache/arrow-datafusion/pull/2076#discussion_r834378662



##########
File path: datafusion-storage/src/lib.rs
##########
@@ -18,7 +18,10 @@
 pub mod object_store;
 
 use chrono::{DateTime, Utc};
-use datafusion_common::ScalarValue;
+use std::{io, result};
+
+/// Result type for operations that could result in an io error
+pub type Result<T> = result::Result<T, io::Error>;

Review comment:
       Im wondering if any impact from using this instead of `DataFusionError::IoError` but i think its fine and of course it would require keeping datafusion-common dependency which would defeat the point of this PR.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org