You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Sid Wagle <sw...@hortonworks.com> on 2014/10/17 02:51:41 UTC

Review Request 26847: Events with Service Checks results in Exceptions in log

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26847/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.


Bugs: AMBARI-7822
    https://issues.apache.org/jira/browse/AMBARI-7822


Repository: ambari


Description
-------

Component is null since it is a service check action.

14:33:08,558 ERROR [Thread-21] ClusterImpl:1452 - ServiceComponentHost lookup exception
org.apache.ambari.server.ServiceComponentNotFoundException: ServiceComponent not found, clusterName=cl1, serviceName=WEBHCAT, serviceComponentName=null
       at org.apache.ambari.server.state.ServiceImpl.getServiceComponent(ServiceImpl.java:279)
       at org.apache.ambari.server.state.cluster.ClusterImpl.processServiceComponentHostEvents(ClusterImpl.java:1448)


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java d12b6fd 
  ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java affa4c9 

Diff: https://reviews.apache.org/r/26847/diff/


Testing
-------


Thanks,

Sid Wagle


Re: Review Request 26847: Events with Service Checks results in Exceptions in log

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26847/#review57088
-----------------------------------------------------------

Ship it!


Ship It!

- Alejandro Fernandez


On Oct. 17, 2014, 1:41 a.m., Sid Wagle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26847/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2014, 1:41 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-7822
>     https://issues.apache.org/jira/browse/AMBARI-7822
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Component is null since it is a service check action.
> 
> 14:33:08,558 ERROR [Thread-21] ClusterImpl:1452 - ServiceComponentHost lookup exception
> org.apache.ambari.server.ServiceComponentNotFoundException: ServiceComponent not found, clusterName=cl1, serviceName=WEBHCAT, serviceComponentName=null
>        at org.apache.ambari.server.state.ServiceImpl.getServiceComponent(ServiceImpl.java:279)
>        at org.apache.ambari.server.state.cluster.ClusterImpl.processServiceComponentHostEvents(ClusterImpl.java:1448)
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java d12b6fd 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java affa4c9 
> 
> Diff: https://reviews.apache.org/r/26847/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Added null check
>   https://reviews.apache.org/media/uploaded/files/2014/10/17/29ddeca9-db82-4325-b232-c740c7885ee2__AMBARI-7822-1.patch
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>


Re: Review Request 26847: Events with Service Checks results in Exceptions in log

Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26847/#review57089
-----------------------------------------------------------

Ship it!


Ship It!

- Yusaku Sako


On Oct. 17, 2014, 1:42 a.m., Sid Wagle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26847/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2014, 1:42 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-7822
>     https://issues.apache.org/jira/browse/AMBARI-7822
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Component is null since it is a service check action.
> 
> 14:33:08,558 ERROR [Thread-21] ClusterImpl:1452 - ServiceComponentHost lookup exception
> org.apache.ambari.server.ServiceComponentNotFoundException: ServiceComponent not found, clusterName=cl1, serviceName=WEBHCAT, serviceComponentName=null
>        at org.apache.ambari.server.state.ServiceImpl.getServiceComponent(ServiceImpl.java:279)
>        at org.apache.ambari.server.state.cluster.ClusterImpl.processServiceComponentHostEvents(ClusterImpl.java:1448)
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java d12b6fd 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java affa4c9 
> 
> Diff: https://reviews.apache.org/r/26847/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Added null check
>   https://reviews.apache.org/media/uploaded/files/2014/10/17/29ddeca9-db82-4325-b232-c740c7885ee2__AMBARI-7822-1.patch
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>


Re: Review Request 26847: Events with Service Checks results in Exceptions in log

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26847/#review57628
-----------------------------------------------------------

Ship it!


Ship It!

- Alejandro Fernandez


On Oct. 21, 2014, 6:05 p.m., Sid Wagle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26847/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2014, 6:05 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-7822
>     https://issues.apache.org/jira/browse/AMBARI-7822
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Component is null since it is a service check action.
> 
> 14:33:08,558 ERROR [Thread-21] ClusterImpl:1452 - ServiceComponentHost lookup exception
> org.apache.ambari.server.ServiceComponentNotFoundException: ServiceComponent not found, clusterName=cl1, serviceName=WEBHCAT, serviceComponentName=null
>        at org.apache.ambari.server.state.ServiceImpl.getServiceComponent(ServiceImpl.java:279)
>        at org.apache.ambari.server.state.cluster.ClusterImpl.processServiceComponentHostEvents(ClusterImpl.java:1448)
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java d12b6fd 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java affa4c9 
> 
> Diff: https://reviews.apache.org/r/26847/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Added null check
>   https://reviews.apache.org/media/uploaded/files/2014/10/17/29ddeca9-db82-4325-b232-c740c7885ee2__AMBARI-7822-1.patch
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>


Re: Review Request 26847: Events with Service Checks results in Exceptions in log

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26847/
-----------------------------------------------------------

(Updated Oct. 21, 2014, 6:05 p.m.)


Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Yusaku Sako.


Bugs: AMBARI-7822
    https://issues.apache.org/jira/browse/AMBARI-7822


Repository: ambari


Description
-------

Component is null since it is a service check action.

14:33:08,558 ERROR [Thread-21] ClusterImpl:1452 - ServiceComponentHost lookup exception
org.apache.ambari.server.ServiceComponentNotFoundException: ServiceComponent not found, clusterName=cl1, serviceName=WEBHCAT, serviceComponentName=null
       at org.apache.ambari.server.state.ServiceImpl.getServiceComponent(ServiceImpl.java:279)
       at org.apache.ambari.server.state.cluster.ClusterImpl.processServiceComponentHostEvents(ClusterImpl.java:1448)


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java d12b6fd 
  ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java affa4c9 

Diff: https://reviews.apache.org/r/26847/diff/


Testing
-------


File Attachments
----------------

Added null check
  https://reviews.apache.org/media/uploaded/files/2014/10/17/29ddeca9-db82-4325-b232-c740c7885ee2__AMBARI-7822-1.patch


Thanks,

Sid Wagle


Re: Review Request 26847: Events with Service Checks results in Exceptions in log

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26847/
-----------------------------------------------------------

(Updated Oct. 17, 2014, 1:42 a.m.)


Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Yusaku Sako.


Bugs: AMBARI-7822
    https://issues.apache.org/jira/browse/AMBARI-7822


Repository: ambari


Description
-------

Component is null since it is a service check action.

14:33:08,558 ERROR [Thread-21] ClusterImpl:1452 - ServiceComponentHost lookup exception
org.apache.ambari.server.ServiceComponentNotFoundException: ServiceComponent not found, clusterName=cl1, serviceName=WEBHCAT, serviceComponentName=null
       at org.apache.ambari.server.state.ServiceImpl.getServiceComponent(ServiceImpl.java:279)
       at org.apache.ambari.server.state.cluster.ClusterImpl.processServiceComponentHostEvents(ClusterImpl.java:1448)


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java d12b6fd 
  ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java affa4c9 

Diff: https://reviews.apache.org/r/26847/diff/


Testing
-------


File Attachments
----------------

Added null check
  https://reviews.apache.org/media/uploaded/files/2014/10/17/29ddeca9-db82-4325-b232-c740c7885ee2__AMBARI-7822-1.patch


Thanks,

Sid Wagle


Re: Review Request 26847: Events with Service Checks results in Exceptions in log

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26847/
-----------------------------------------------------------

(Updated Oct. 17, 2014, 1:41 a.m.)


Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.


Bugs: AMBARI-7822
    https://issues.apache.org/jira/browse/AMBARI-7822


Repository: ambari


Description
-------

Component is null since it is a service check action.

14:33:08,558 ERROR [Thread-21] ClusterImpl:1452 - ServiceComponentHost lookup exception
org.apache.ambari.server.ServiceComponentNotFoundException: ServiceComponent not found, clusterName=cl1, serviceName=WEBHCAT, serviceComponentName=null
       at org.apache.ambari.server.state.ServiceImpl.getServiceComponent(ServiceImpl.java:279)
       at org.apache.ambari.server.state.cluster.ClusterImpl.processServiceComponentHostEvents(ClusterImpl.java:1448)


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java d12b6fd 
  ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java affa4c9 

Diff: https://reviews.apache.org/r/26847/diff/


Testing
-------


File Attachments (updated)
----------------

Added null check
  https://reviews.apache.org/media/uploaded/files/2014/10/17/29ddeca9-db82-4325-b232-c740c7885ee2__AMBARI-7822-1.patch


Thanks,

Sid Wagle


Re: Review Request 26847: Events with Service Checks results in Exceptions in log

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26847/#review57085
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
<https://reviews.apache.org/r/26847/#comment97570>

    This may need a null check before calling getName()


- Alejandro Fernandez


On Oct. 17, 2014, 12:51 a.m., Sid Wagle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26847/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2014, 12:51 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-7822
>     https://issues.apache.org/jira/browse/AMBARI-7822
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Component is null since it is a service check action.
> 
> 14:33:08,558 ERROR [Thread-21] ClusterImpl:1452 - ServiceComponentHost lookup exception
> org.apache.ambari.server.ServiceComponentNotFoundException: ServiceComponent not found, clusterName=cl1, serviceName=WEBHCAT, serviceComponentName=null
>        at org.apache.ambari.server.state.ServiceImpl.getServiceComponent(ServiceImpl.java:279)
>        at org.apache.ambari.server.state.cluster.ClusterImpl.processServiceComponentHostEvents(ClusterImpl.java:1448)
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java d12b6fd 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java affa4c9 
> 
> Diff: https://reviews.apache.org/r/26847/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>