[GitHub] [iceberg] ConeyLiu commented on a diff in pull request #5659: Core: Support set system level properties with environmental variables

["ConeyLiu (via GitHub)" <gi...@apache.org>]

ConeyLiu commented on code in PR #5659:
URL: https://github.com/apache/iceberg/pull/5659#discussion_r1160509216


##########
core/src/main/java/org/apache/iceberg/SystemProperties.java:
##########
@@ -18,7 +18,9 @@
  */
 package org.apache.iceberg;
 
-/** Configuration properties that are controlled by Java system properties. */
+/**
+ * Configuration properties that are controlled by Java system properties or environmental variable

Review Comment:
   What about adding a new class `RuntimeInfo` to handle both properties and env? And deprecate `SystemProperties`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org