You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "Ryo Okubo (JIRA)" <ji...@apache.org> on 2014/11/10 03:11:34 UTC
[jira] [Issue Comment Deleted] (TS-3156) Mutex[Try]Lock bool()
operator change and unused API removal
[ https://issues.apache.org/jira/browse/TS-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryo Okubo updated TS-3156:
--------------------------
Comment: was deleted
(was: Hi Powell,
As you said, this issue may be caused by an uninitialized lock.
I tried to print strerror() by writing that code:
{noformat}
static inline int
ink_mutex_acquire(ink_mutex * m)
{
int err = pthread_mutex_lock(m);
if (err != 0) {
fprintf(stderr, "Failed to acquire mutex lock: %s", strerror(err));
abort();
}
return 0;
}
{noformat}
then I got )
> Mutex[Try]Lock bool() operator change and unused API removal
> ------------------------------------------------------------
>
> Key: TS-3156
> URL: https://issues.apache.org/jira/browse/TS-3156
> Project: Traffic Server
> Issue Type: Improvement
> Components: Core
> Reporter: Powell Molleti
> Assignee: James Peach
> Priority: Minor
> Labels: review
> Fix For: 5.2.0
>
> Attachments: MutexLock-ats.patch, MutexLock-ats.patch
>
>
> Removed unused constructor in MutexLock along with set_and_take() method, had to change FORCE_PLUGIN_MUTEX() for that. Removed release() method.
> default bool and ! operator from both MutexLock and MutexTryLock with is_locked() API. Changes if (lock) to if (lock.is_locked()) across the code base.
> Ran make test will be performing more system testing. Posted before for early comments / feedback.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)