You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "jwilliams-ocient (via GitHub)" <gi...@apache.org> on 2023/05/02 18:25:56 UTC
[GitHub] [superset] jwilliams-ocient opened a new issue, #23907: fix(ocient): convert GIS data types to geoJSON for the Ocient engine
jwilliams-ocient opened a new issue, #23907:
URL: https://github.com/apache/superset/issues/23907
The Ocient engine currently emits GIS objects that are incompatible with any of the deck.gl visualization charts. The existing implementation attempts to emit coordinate arrays which are invalid for polygons with holes and a few other edge cases.
**The Ocient engine should adopt geoJSON for _all_ geospatial types emitted by Ocient.**
Ocient alse has a... unique way of encoding geometry collections that results in Point or LineString objects being encoded as Polygons. Obviously, a geoJSON polygon containing a single point in its exterior ring produces invalid geoJSON,
See: https://github.com/apache/superset/pull/23814/files
#### How to reproduce the bug
1. Execute any query emitting a polygon object using SQL Lab
2. Create a dataset from the query in (1)
3. Create any deck.gl chart
### Expected results
N/A
### Actual results
N/A
#### Screenshots
N/A
### Environment
All environments
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [ ] I have reproduced the issue with at least the latest released version of superset.
- [ ] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
Add any other context about the problem here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] fix(ocient): convert GIS data types to geoJSON for the Ocient engine [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed issue #23907: fix(ocient): convert GIS data types to geoJSON for the Ocient engine
URL: https://github.com/apache/superset/issues/23907
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] fix(ocient): convert GIS data types to geoJSON for the Ocient engine [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #23907:
URL: https://github.com/apache/superset/issues/23907#issuecomment-1968326254
I'd love to support this, but I'm not sure how. Is it something you'd be willing to propose/submit a fix for?
Closing this as stale since it's been silent for so long, and we're trying to steer toward a more actionable Issues backlog. We can re-open this if you think it's needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org