You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Boglarka Egyed <bo...@apache.org> on 2017/12/01 17:30:24 UTC
Review Request 64251: SQOOP-3266: Update 3rd party and manual test
running related info in COMPILING.txt
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64251/
-----------------------------------------------------------
Review request for Sqoop, Fero Szabo and Szabolcs Vasas.
Bugs: SQOOP-3266
https://issues.apache.org/jira/browse/SQOOP-3266
Repository: sqoop-trunk
Description
-------
MSSQL tests have been added to 3rd part test suite in SQOOP-3174, COMPILING.txt should be updated accordingly. Also, 3rd party test execution on native database servers could be more verbose.
Diffs
-----
COMPILING.txt f531dd49a77d86b747478b4b8aad1a62d63515af
Diff: https://reviews.apache.org/r/64251/diff/1/
Testing
-------
Only text change.
Thanks,
Boglarka Egyed
Re: Review Request 64251: SQOOP-3266: Update 3rd party and manual test
running related info in COMPILING.txt
Posted by Boglarka Egyed <bo...@apache.org>.
> On Dec. 7, 2017, 4:11 p.m., Fero Szabo wrote:
> > COMPILING.txt
> > Lines 105-106 (patched)
> > <https://reviews.apache.org/r/64251/diff/1/?file=1905879#file1905879line105>
> >
> > I believe there is a typo here:
> > qoop.test.oracle.xy >> sqoop.test.oracle.xy
> >
> > Also, a question:
> > Why is sqoop.test.oracle.databasename not specified? is it not needed or supported?
Thanks for catching the typo!
There is no sqoop.test.oracle.databasename property currently in Sqoop, the name of the database should be added to the end of the connect string for Oracle.
- Boglarka
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64251/#review193127
-----------------------------------------------------------
On Dec. 1, 2017, 5:30 p.m., Boglarka Egyed wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64251/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2017, 5:30 p.m.)
>
>
> Review request for Sqoop, Fero Szabo and Szabolcs Vasas.
>
>
> Bugs: SQOOP-3266
> https://issues.apache.org/jira/browse/SQOOP-3266
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> MSSQL tests have been added to 3rd part test suite in SQOOP-3174, COMPILING.txt should be updated accordingly. Also, 3rd party test execution on native database servers could be more verbose.
>
>
> Diffs
> -----
>
> COMPILING.txt f531dd49a77d86b747478b4b8aad1a62d63515af
>
>
> Diff: https://reviews.apache.org/r/64251/diff/1/
>
>
> Testing
> -------
>
> Only text change.
>
>
> Thanks,
>
> Boglarka Egyed
>
>
Re: Review Request 64251: SQOOP-3266: Update 3rd party and manual test
running related info in COMPILING.txt
Posted by Fero Szabo via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64251/#review193127
-----------------------------------------------------------
COMPILING.txt
Lines 105-106 (patched)
<https://reviews.apache.org/r/64251/#comment271630>
I believe there is a typo here:
qoop.test.oracle.xy >> sqoop.test.oracle.xy
Also, a question:
Why is sqoop.test.oracle.databasename not specified? is it not needed or supported?
- Fero Szabo
On Dec. 1, 2017, 5:30 p.m., Boglarka Egyed wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64251/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2017, 5:30 p.m.)
>
>
> Review request for Sqoop, Fero Szabo and Szabolcs Vasas.
>
>
> Bugs: SQOOP-3266
> https://issues.apache.org/jira/browse/SQOOP-3266
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> MSSQL tests have been added to 3rd part test suite in SQOOP-3174, COMPILING.txt should be updated accordingly. Also, 3rd party test execution on native database servers could be more verbose.
>
>
> Diffs
> -----
>
> COMPILING.txt f531dd49a77d86b747478b4b8aad1a62d63515af
>
>
> Diff: https://reviews.apache.org/r/64251/diff/1/
>
>
> Testing
> -------
>
> Only text change.
>
>
> Thanks,
>
> Boglarka Egyed
>
>
Re: Review Request 64251: SQOOP-3266: Update 3rd party and manual test
running related info in COMPILING.txt
Posted by Boglarka Egyed <bo...@apache.org>.
> On Dec. 13, 2017, 10:17 a.m., Szabolcs Vasas wrote:
> > COMPILING.txt
> > Lines 147 (patched)
> > <https://reviews.apache.org/r/64251/diff/2/?file=1910469#file1910469line147>
> >
> > I think the correct parameter name here is ms.sqlserver.username, can you please double check?
You are totally right, thanks for catching this!
- Boglarka
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64251/#review193660
-----------------------------------------------------------
On Dec. 7, 2017, 4:46 p.m., Boglarka Egyed wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64251/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2017, 4:46 p.m.)
>
>
> Review request for Sqoop, Fero Szabo and Szabolcs Vasas.
>
>
> Bugs: SQOOP-3266
> https://issues.apache.org/jira/browse/SQOOP-3266
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> MSSQL tests have been added to 3rd part test suite in SQOOP-3174, COMPILING.txt should be updated accordingly. Also, 3rd party test execution on native database servers could be more verbose.
>
>
> Diffs
> -----
>
> COMPILING.txt f531dd49a77d86b747478b4b8aad1a62d63515af
>
>
> Diff: https://reviews.apache.org/r/64251/diff/2/
>
>
> Testing
> -------
>
> Only text change.
>
>
> Thanks,
>
> Boglarka Egyed
>
>
Re: Review Request 64251: SQOOP-3266: Update 3rd party and manual test
running related info in COMPILING.txt
Posted by Szabolcs Vasas <va...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64251/#review193660
-----------------------------------------------------------
Hi Bogi,
Thank you for filling this gap in our documentation, I have found a few minor things, please double check them.
Thanks,
Szabolcs
COMPILING.txt
Lines 147 (patched)
<https://reviews.apache.org/r/64251/#comment272243>
I think the correct parameter name here is ms.sqlserver.username, can you please double check?
COMPILING.txt
Lines 148 (patched)
<https://reviews.apache.org/r/64251/#comment272244>
I think the correct parameter name here is ms.sqlserver.password, can you please double check?
- Szabolcs Vasas
On Dec. 7, 2017, 4:46 p.m., Boglarka Egyed wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64251/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2017, 4:46 p.m.)
>
>
> Review request for Sqoop, Fero Szabo and Szabolcs Vasas.
>
>
> Bugs: SQOOP-3266
> https://issues.apache.org/jira/browse/SQOOP-3266
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> MSSQL tests have been added to 3rd part test suite in SQOOP-3174, COMPILING.txt should be updated accordingly. Also, 3rd party test execution on native database servers could be more verbose.
>
>
> Diffs
> -----
>
> COMPILING.txt f531dd49a77d86b747478b4b8aad1a62d63515af
>
>
> Diff: https://reviews.apache.org/r/64251/diff/2/
>
>
> Testing
> -------
>
> Only text change.
>
>
> Thanks,
>
> Boglarka Egyed
>
>
Re: Review Request 64251: SQOOP-3266: Update 3rd party and manual test
running related info in COMPILING.txt
Posted by Fero Szabo via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64251/#review193139
-----------------------------------------------------------
Ship it!
Ship It!
- Fero Szabo
On Dec. 7, 2017, 4:46 p.m., Boglarka Egyed wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64251/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2017, 4:46 p.m.)
>
>
> Review request for Sqoop, Fero Szabo and Szabolcs Vasas.
>
>
> Bugs: SQOOP-3266
> https://issues.apache.org/jira/browse/SQOOP-3266
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> MSSQL tests have been added to 3rd part test suite in SQOOP-3174, COMPILING.txt should be updated accordingly. Also, 3rd party test execution on native database servers could be more verbose.
>
>
> Diffs
> -----
>
> COMPILING.txt f531dd49a77d86b747478b4b8aad1a62d63515af
>
>
> Diff: https://reviews.apache.org/r/64251/diff/2/
>
>
> Testing
> -------
>
> Only text change.
>
>
> Thanks,
>
> Boglarka Egyed
>
>
Re: Review Request 64251: SQOOP-3266: Update 3rd party and manual test
running related info in COMPILING.txt
Posted by Szabolcs Vasas <va...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64251/#review193783
-----------------------------------------------------------
Ship it!
Ship It!
- Szabolcs Vasas
On Dec. 13, 2017, 10:59 a.m., Boglarka Egyed wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64251/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2017, 10:59 a.m.)
>
>
> Review request for Sqoop, Fero Szabo and Szabolcs Vasas.
>
>
> Bugs: SQOOP-3266
> https://issues.apache.org/jira/browse/SQOOP-3266
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> MSSQL tests have been added to 3rd part test suite in SQOOP-3174, COMPILING.txt should be updated accordingly. Also, 3rd party test execution on native database servers could be more verbose.
>
>
> Diffs
> -----
>
> COMPILING.txt f531dd49a77d86b747478b4b8aad1a62d63515af
>
>
> Diff: https://reviews.apache.org/r/64251/diff/3/
>
>
> Testing
> -------
>
> Only text change.
>
>
> Thanks,
>
> Boglarka Egyed
>
>
Re: Review Request 64251: SQOOP-3266: Update 3rd party and manual test
running related info in COMPILING.txt
Posted by Boglarka Egyed <bo...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64251/
-----------------------------------------------------------
(Updated Dec. 13, 2017, 10:59 a.m.)
Review request for Sqoop, Fero Szabo and Szabolcs Vasas.
Changes
-------
Correct MSSQL username/password property names
Bugs: SQOOP-3266
https://issues.apache.org/jira/browse/SQOOP-3266
Repository: sqoop-trunk
Description
-------
MSSQL tests have been added to 3rd part test suite in SQOOP-3174, COMPILING.txt should be updated accordingly. Also, 3rd party test execution on native database servers could be more verbose.
Diffs (updated)
-----
COMPILING.txt f531dd49a77d86b747478b4b8aad1a62d63515af
Diff: https://reviews.apache.org/r/64251/diff/3/
Changes: https://reviews.apache.org/r/64251/diff/2-3/
Testing
-------
Only text change.
Thanks,
Boglarka Egyed
Re: Review Request 64251: SQOOP-3266: Update 3rd party and manual test
running related info in COMPILING.txt
Posted by Boglarka Egyed <bo...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64251/
-----------------------------------------------------------
(Updated Dec. 7, 2017, 4:46 p.m.)
Review request for Sqoop, Fero Szabo and Szabolcs Vasas.
Changes
-------
Fixing typo
Bugs: SQOOP-3266
https://issues.apache.org/jira/browse/SQOOP-3266
Repository: sqoop-trunk
Description
-------
MSSQL tests have been added to 3rd part test suite in SQOOP-3174, COMPILING.txt should be updated accordingly. Also, 3rd party test execution on native database servers could be more verbose.
Diffs (updated)
-----
COMPILING.txt f531dd49a77d86b747478b4b8aad1a62d63515af
Diff: https://reviews.apache.org/r/64251/diff/2/
Changes: https://reviews.apache.org/r/64251/diff/1-2/
Testing
-------
Only text change.
Thanks,
Boglarka Egyed