You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Qian Zhang (JIRA)" <ji...@apache.org> on 2019/04/15 13:30:00 UTC

[jira] [Commented] (MESOS-9684) Backport docker manifest v2s2 support to 1.5.x

    [ https://issues.apache.org/jira/browse/MESOS-9684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817968#comment-16817968 ] 

Qian Zhang commented on MESOS-9684:
-----------------------------------

Backported to 1.5.x:
commit 79c0cb0b3ed09a4801e54895806409f4e8979fe7
Author: Gilbert Song <so...@gmail.com>
Date:   Fri Apr 12 17:13:58 2019 +0800

    Fixed the URI fetcher image fetch test failure on windows.
    
    Review: https://reviews.apache.org/r/70398/

 src/tests/uri_fetcher_tests.cpp | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

commit a8bc01381ef5b744e91b42bb78ca951096bf2e13
Author: Andrei Budnik <ab...@mesosphere.com>
Date:   Fri Apr 5 13:06:49 2019 +0200

    Fixed use-after-free bug in Docker provisioner store.
    
    Deferred lambda callback of the `moveLayers()` to the `StoreProcess`
    to prevent use-after-free of the process object since the callback
    refers to the `StoreProcess` class variable `flags`.
    
    Review: https://reviews.apache.org/r/70405

 src/slave/containerizer/mesos/provisioner/docker/store.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

commit 392bbbf0156648c7e57e188693f697c6f46dec96
Author: Gilbert Song <so...@gmail.com>
Date:   Wed Mar 27 17:33:19 2019 -0700

    Added a unit test for Mesos containerizer image force pulling.
    
    Review: https://reviews.apache.org/r/70366

 src/tests/containerizer/provisioner_docker_tests.cpp | 127 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 127 insertions(+)

commit a0772ea7ae4b22e81ecbb87bc85b6304b30daec3
Author: Gilbert Song <so...@gmail.com>
Date:   Fri Mar 22 10:37:46 2019 -0700

    Added gcr registry test.
    
    Review: https://reviews.apache.org/r/70291

 src/tests/containerizer/provisioner_docker_tests.cpp | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

commit 038372ea9f251765e09891f8cbf152e5e7b6cb22
Author: Gilbert Song <so...@gmail.com>
Date:   Wed Mar 27 12:03:00 2019 -0700

    Fixed docker fetcher plugin unit test for v2s2 change.
    
    Review: https://reviews.apache.org/r/70290

 src/tests/uri_fetcher_tests.cpp | 60 ++++++++++++++++++++++++++----------------------------------
 1 file changed, 26 insertions(+), 34 deletions(-)

commit 85a5827178065bfb1ef74cd0b672fc6f1c965d76
Author: Gilbert Song <so...@gmail.com>
Date:   Sat Mar 23 21:14:15 2019 -0700

    Added a TODO for additional URLs support.
    
    Review: https://reviews.apache.org/r/70289

 src/uri/fetchers/docker.cpp | 2 ++
 1 file changed, 2 insertions(+)

commit 0dcc0f06d62743eb14eb4fa82d678f4f53c6c882
Author: Gilbert Song <so...@gmail.com>
Date:   Fri Mar 22 00:32:30 2019 -0700

    Supported docker manifest v2 schema2.
    
    Review: https://reviews.apache.org/r/70288

 src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp | 266 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------
 src/slave/containerizer/mesos/provisioner/docker/store.cpp           |  56 ++++++++++++++++---
 src/uri/fetchers/docker.cpp                                          | 296 ++++++++++++++++++++++++++++++++++++++-----------------------------------------------------------
 3 files changed, 396 insertions(+), 222 deletions(-)

commit e7457c1a4d6891b2f2803770c3b2aeb318d8e32d
Author: Gilbert Song <so...@gmail.com>
Date:   Mon Apr 1 22:42:53 2019 -0700

    Added protobuf for docker v2 schema2 config_digest in 'Image'.
    
    Review: https://reviews.apache.org/r/70365

 src/slave/containerizer/mesos/provisioner/docker/message.proto | 4 ++++
 1 file changed, 4 insertions(+)

commit fda69fc236afed986ff9281006e39db7b606abcb
Author: Gilbert Song <so...@gmail.com>
Date:   Mon Apr 1 16:11:43 2019 -0700

    Refactored the UCR docker store to construct 'Image' proto at pullers.
    
    This refactoring is needed for supporting docker manifest v2s2 because
    the puller has to let the docker store knows the v1 config, and this
    is also needed for garbage collecting the v1 config in the image layer
    store.
    
    Review: https://reviews.apache.org/r/70354

 src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp     | 20 ++++++++++++++------
 src/slave/containerizer/mesos/provisioner/docker/local_puller.hpp     |  2 +-
 src/slave/containerizer/mesos/provisioner/docker/message.proto        |  4 +++-
 src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp | 28 +++++++---------------------
 src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp | 12 ++----------
 src/slave/containerizer/mesos/provisioner/docker/puller.hpp           |  4 +++-
 src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp  | 28 +++++++++++++++++-----------
 src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp  |  2 +-
 src/slave/containerizer/mesos/provisioner/docker/store.cpp            | 16 ++++++++--------
 src/tests/containerizer/provisioner_docker_tests.cpp                  | 20 ++++++++++++++------
 10 files changed, 70 insertions(+), 66 deletions(-)

commit d69beeb182719e0bb8b9d75a45bc3fb96a59aa8f
Author: Gilbert Song <so...@gmail.com>
Date:   Sat Mar 23 20:54:08 2019 -0700

    Added 'prettyjws' option to docker manifest V2 Schema1 accept header.
    
    Review: https://reviews.apache.org/r/70287

 src/uri/fetchers/docker.cpp | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

> Backport docker manifest v2s2 support to 1.5.x
> ----------------------------------------------
>
>                 Key: MESOS-9684
>                 URL: https://issues.apache.org/jira/browse/MESOS-9684
>             Project: Mesos
>          Issue Type: Task
>            Reporter: Gilbert Song
>            Assignee: Qian Zhang
>            Priority: Major
>              Labels: containerization
>             Fix For: 1.5.4
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)