You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/14 03:26:41 UTC

[GitHub] [shardingsphere] isHuangXin opened a new pull request, #22161: test(issue-21465): set-sharding-hint-database-value-statement

isHuangXin opened a new pull request, #22161:
URL: https://github.com/apache/shardingsphere/pull/22161

   For #21465 .
   
   Changes proposed in this pull request:
     - Add test unit for SetShardingHintDatabaseValueStatement.
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [ ] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the pull request.
   - [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] codecov-commenter commented on pull request #22161: test(issue-21465): set-sharding-hint-database-value-statement

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #22161:
URL: https://github.com/apache/shardingsphere/pull/22161#issuecomment-1313067768

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/22161?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#22161](https://codecov.io/gh/apache/shardingsphere/pull/22161?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e7323ca) into [master](https://codecov.io/gh/apache/shardingsphere/commit/cb5dc166fa606d8ffd22ec4aca6b3774e994226b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cb5dc16) will **increase** coverage by `0.00%`.
   > The diff coverage is `71.42%`.
   
   ```diff
   @@            Coverage Diff            @@
   ##             master   #22161   +/-   ##
   =========================================
     Coverage     61.03%   61.03%           
   - Complexity     2544     2546    +2     
   =========================================
     Files          4120     4121    +1     
     Lines         57334    57341    +7     
     Branches       9706     9707    +1     
   =========================================
   + Hits          34991    34999    +8     
   + Misses        19393    19391    -2     
   - Partials       2950     2951    +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/22161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...SetShardingHintDatabaseValueStatementTestCase.java](https://codecov.io/gh/apache/shardingsphere/pull/22161/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3Qvc3FsL3BhcnNlci9pbnRlcm5hbC9qYXhiL2Nhc2VzL2RvbWFpbi9zdGF0ZW1lbnQvZGlzdHNxbC9yYWwvU2V0U2hhcmRpbmdIaW50RGF0YWJhc2VWYWx1ZVN0YXRlbWVudFRlc3RDYXNlLmphdmE=) | `100.00% <ø> (ø)` | |
   | [...t/SetShardingHintDatabaseValueStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/22161/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3Qvc3FsL3BhcnNlci9pbnRlcm5hbC9hc3NlcnRzL3N0YXRlbWVudC9kaXN0c3FsL3JhbC9pbXBsL2hpbnQvU2V0U2hhcmRpbmdIaW50RGF0YWJhc2VWYWx1ZVN0YXRlbWVudEFzc2VydC5qYXZh) | `60.00% <60.00%> (ø)` | |
   | [...ement/distsql/ral/impl/HintRALStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/22161/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3Qvc3FsL3BhcnNlci9pbnRlcm5hbC9hc3NlcnRzL3N0YXRlbWVudC9kaXN0c3FsL3JhbC9pbXBsL0hpbnRSQUxTdGF0ZW1lbnRBc3NlcnQuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...handler/distsql/ral/hint/enums/HintSourceType.java](https://codecov.io/gh/apache/shardingsphere/pull/22161/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL2hpbnQvZW51bXMvSGludFNvdXJjZVR5cGUuamF2YQ==) | `42.85% <0.00%> (+42.85%)` | :arrow_up: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] RaigorJiang merged pull request #22161: test(issue-21465): set-sharding-hint-database-value-statement

Posted by GitBox <gi...@apache.org>.
RaigorJiang merged PR #22161:
URL: https://github.com/apache/shardingsphere/pull/22161


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org