You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2023/12/20 16:33:01 UTC

[I] Cannot regenerate protobuf source code using instructions in the documentation [arrow-datafusion]

andygrove opened a new issue, #8602:
URL: https://github.com/apache/arrow-datafusion/issues/8602

   ### Describe the bug
   
   I'm trying to regenerate protobuf source code by running `regen.sh` but it fails with an error:
   
   ```
   $ ./regen.sh 
       Finished dev [unoptimized + debuginfo] target(s) in 0.99s
        Running `/home/andy/git/apache/arrow-datafusion/target/debug/gen`
   Error: "protobuf compilation failed: protoc failed: datafusion.proto: This file contains proto3 optional fields, but --experimental_allow_proto3_optional was not set.\n"
   ```
   
   I am using libprotoc 3.12.4 as suggested by the docs. 
   
   I see a comment in `datafusion.proto` ... `"optional" keyword is stable in protoc 3.15`, so perhaps our docs are out of date and we now require 3.15? If so, we should update the docs.
   
   
   ### To Reproduce
   
   _No response_
   
   ### Expected behavior
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Cannot regenerate protobuf source code using instructions in the documentation [arrow-datafusion]

Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove closed issue #8602: Cannot regenerate protobuf source code using instructions in the documentation
URL: https://github.com/apache/arrow-datafusion/issues/8602


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Cannot regenerate protobuf source code using instructions in the documentation [arrow-datafusion]

Posted by "devinjdangelo (via GitHub)" <gi...@apache.org>.
devinjdangelo commented on issue #8602:
URL: https://github.com/apache/arrow-datafusion/issues/8602#issuecomment-1865122288

   I hit this while working on https://github.com/apache/arrow-datafusion/pull/8605
   
   Adding `.protoc_arg("--experimental_allow_proto3_optional")` to datafusion/proto/gen/src/main.rs seems to fix the issue.
   
   I am also using libprotoc 3.12.4, which appears to be the latest release available via apt on ubuntu 22.04.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org