[GitHub] [apisix] ronething commented on a diff in pull request #8640: feat: stream subsystem support kubernetes service discovery

[GitBox <gi...@apache.org>]

ronething commented on code in PR #8640:
URL: https://github.com/apache/apisix/pull/8640#discussion_r1065540614


##########
ci/linux_openresty_1_19_runner.sh:
##########
@@ -17,5 +17,5 @@
 #
 
 
-export OPENRESTY_VERSION=1.19.3.2
+export OPENRESTY_VERSION=1.19.9.1

Review Comment:
   > We have promised to support the latest three versions of OpenResty, so we still need to cover 1.19.3.2.
   What about updating the test case and only running it when the version is matched, like https://github.com/apache/apisix/blob/release/2.14/t/plugin/ext-plugin/sanity-openresty-1-19.t?
   
   ok, i will try it later.
   
   > It would be better to refuse to start when the OpenResty is too old and k8s discovery is used in the stream.
   
   Is it a good choice if we add a boolean field like `enable_stream`(default is `false`) into `apisix/discovery/kubernetes/schema.lua` as a property and check OpenResty version if `enable_stream` is `true`? Can you give me some hints? thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org