You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2021/01/03 13:55:12 UTC
[commons-compress] branch master updated: Fix compiler warnings.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-compress.git
The following commit(s) were added to refs/heads/master by this push:
new 7fdf1ed Fix compiler warnings.
7fdf1ed is described below
commit 7fdf1edbb0dfad9854407aa020f47c9ea01ceaf4
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sun Jan 3 08:55:08 2021 -0500
Fix compiler warnings.
---
.../Deflate64CompressorInputStreamTest.java | 31 ++++++++++++----------
1 file changed, 17 insertions(+), 14 deletions(-)
diff --git a/src/test/java/org/apache/commons/compress/compressors/deflate64/Deflate64CompressorInputStreamTest.java b/src/test/java/org/apache/commons/compress/compressors/deflate64/Deflate64CompressorInputStreamTest.java
index f73b2c2..db8bef2 100644
--- a/src/test/java/org/apache/commons/compress/compressors/deflate64/Deflate64CompressorInputStreamTest.java
+++ b/src/test/java/org/apache/commons/compress/compressors/deflate64/Deflate64CompressorInputStreamTest.java
@@ -45,31 +45,35 @@ public class Deflate64CompressorInputStreamTest {
@Test
public void readWhenClosed() throws Exception {
- final Deflate64CompressorInputStream input = new Deflate64CompressorInputStream(nullDecoder);
- assertEquals(-1, input.read());
- assertEquals(-1, input.read(new byte[1]));
- assertEquals(-1, input.read(new byte[1], 0, 1));
+ try (final Deflate64CompressorInputStream input = new Deflate64CompressorInputStream(nullDecoder)) {
+ assertEquals(-1, input.read());
+ assertEquals(-1, input.read(new byte[1]));
+ assertEquals(-1, input.read(new byte[1], 0, 1));
+ }
}
@Test
public void properSizeWhenClosed() throws Exception {
- final Deflate64CompressorInputStream input = new Deflate64CompressorInputStream(nullDecoder);
- assertEquals(0, input.available());
+ try (final Deflate64CompressorInputStream input = new Deflate64CompressorInputStream(nullDecoder)) {
+ assertEquals(0, input.available());
+ }
}
@Test
public void delegatesAvailable() throws Exception {
Mockito.when(decoder.available()).thenReturn(1024);
- final Deflate64CompressorInputStream input = new Deflate64CompressorInputStream(decoder);
- assertEquals(1024, input.available());
+ try (final Deflate64CompressorInputStream input = new Deflate64CompressorInputStream(decoder)) {
+ assertEquals(1024, input.available());
+ }
}
@Test
public void closeCallsDecoder() throws Exception {
- final Deflate64CompressorInputStream input = new Deflate64CompressorInputStream(decoder);
- input.close();
+ try (final Deflate64CompressorInputStream input = new Deflate64CompressorInputStream(decoder)) {
+ // empty
+ }
Mockito.verify(decoder, times(1)).close();
}
@@ -77,10 +81,9 @@ public class Deflate64CompressorInputStreamTest {
@Test
public void closeIsDelegatedJustOnce() throws Exception {
- final Deflate64CompressorInputStream input = new Deflate64CompressorInputStream(decoder);
-
- input.close();
- input.close();
+ try (final Deflate64CompressorInputStream input = new Deflate64CompressorInputStream(decoder)) {
+ input.close();
+ }
Mockito.verify(decoder, times(1)).close();
}