[GitHub] [lucene] rmuir commented on pull request #461: LUCENE-10248: Spanish Plural Stemmer

[GitBox <gi...@apache.org>]

rmuir commented on pull request #461:
URL: https://github.com/apache/lucene/pull/461#issuecomment-975876699


   Hi @xaviersanchez, this contribution looks great.
   
   I'll do another pass on review and give some time for others to review as well.
   
   I did a little investigation at a glance, and I think it is confusing that the current `SpanishMinimalStemmer` is doing aggressive conversions such as `ñ -> n`. I think, as a followup issue, we should `@deprecate` the `SpanishMinimalStemmer` and point users to this one instead? 
   
   `SpanishMinimalStemmer` is not a typical "upstream" algorithm, with academic papers/study from snowball or savoy, and there doesn't seem to be any reason to keep it anymore, except for a legacy index. So we could keep it around for another major release or so but not forever, IMO.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org