You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by 1ambda <gi...@git.apache.org> on 2017/01/04 22:04:54 UTC
[GitHub] zeppelin pull request #1843: [ZEPPELIN-1905] fix: "Clear All Paragraphs" doe...
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/1843
[ZEPPELIN-1905] fix: "Clear All Paragraphs" doens't work in a note
### What is this PR for?
Fixed **Clear all paragraphs** button in a note (I attached a screenshot)
### What type of PR is it?
[Bug Fix]
### Todos
Nothing
### What is the Jira issue?
[ZEPPELIN-1905](https://issues.apache.org/jira/browse/ZEPPELIN-1905)
### How should this be tested?
1. Open a note
2. Run some paragraphs.
3. Click the **Run all paragraphs** button.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin ZEPPELIN-1905/fix-clear-all-paras
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1843.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1843
----
commit 7f95b9bbab389a860d7618d89c5dca6a4141ccf7
Author: 1ambda <1a...@gmail.com>
Date: 2017-01-04T21:59:11Z
fix: Set note content
commit 1f9257e74642845393a418f7bb430282215af83b
Author: 1ambda <1a...@gmail.com>
Date: 2017-01-04T22:00:29Z
fix: Calling isFocused of null (TypeError)
TypeError: Cannot read property 'isFocused' of null
at ChildScope.ParagraphCtrl.$scope.scrollToCursor (paragraph.controller.js:718)
at paragraph.controller.js:708
at Scope.$broadcast (angular.js:17143)
at paragraph.controller.js:1052
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1843: [ZEPPELIN-1905] fix: "Clear All Paragraphs" doens't wo...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/1843
Tested and it works as expected!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1843: [ZEPPELIN-1905] fix: "Clear All Paragraphs" doe...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1843
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1843: [ZEPPELIN-1905] fix: "Clear All Paragraphs" doens't wo...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1843
@1ambda Do you check the personalized mode as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1843: [ZEPPELIN-1905] fix: "Clear All Paragraphs" doens't wo...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1843
LGTM. Will merge it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1843: [ZEPPELIN-1905] fix: "Clear All Paragraphs" doens't wo...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1843
@jongyoul Thanks for opinion :) It works well. I tested like
1. enable shiro
2. add permission per user into a note to check other users can execute clear all or not
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1843: [ZEPPELIN-1905] fix: "Clear All Paragraphs" doens't wo...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/1843
@1ambda Thanks for fixing this bug and detailed explain!
Let me comment after test it :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---