You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2016/06/13 09:44:12 UTC
[GitHub] flink pull request #2095: [FLINK-4046] [runtime] Add direct state transition...
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/2095
[FLINK-4046] [runtime] Add direct state transition from RESTARTING to FAILED
A job can get stuck in FAILING if fail is called on a restarting job which has
not yet reset its ExecutionJobVertices, because these vertices would not call
jobVertexInFinalState. This method, however, must be called in order to transition
from FAILING to FAILED. In order to solve the problem, this PR introduces a direct
state transition from `RESTARTING` to `FAILED`, if `fail` is called when being in state
`RESTARTING`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink fixFailWhileRestarting
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2095.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2095
----
commit 094c6b59eb92cb5a0f3bf41aa92aab399ba4127c
Author: Till Rohrmann <tr...@apache.org>
Date: 2016-06-09T13:54:01Z
[FLINK-4046] [runtime] Add direct state transition from RESTARTING to FAILED
A job can get stuck in FAILING if fail is called on a restarting job which has
not yet reset its ExecutionJobVertices, because these vertices would not call
jobVertexInFinalState. This method, however, must be called in order to transition
from FAILING to FAILED.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2095: [FLINK-4046] [runtime] Add direct state transition from R...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2095
+1 to merge. Both the direct state transition and test are good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2095: [FLINK-4046] [runtime] Add direct state transition from R...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2095
Agreed. I had the same thought regarding checking for any final state right after posting this. ;) +1 to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2095: [FLINK-4046] [runtime] Add direct state transition from R...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2095
PS: Should the early abort check for the `CANCELED` state in `ExecutionGraph.restart()` be extended to any terminal state? The `restart` method assumes that it's the only one transitioning away from `RESTARTING`, which is not the case any more. I think it's not needed, but might lead to confusing log messages when `fail` and `restart` are called concurrently.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2095: [FLINK-4046] [runtime] Add direct state transition...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2095
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2095: [FLINK-4046] [runtime] Add direct state transition from R...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2095
Thanks for the review @uce. I think you're right and we should also accept the `FAILED` state when calling `restart` and simply print a log message instead of throwing the `IllegalStateException`. But I'm not so sure for any terminal state because we should not have reached the state `FINISHED`. This usually indicates a failure and should not go unnoticed.
I will add the `FAILED` check and then merge the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---