[GitHub] [logging-log4j-kotlin] mikaello commented on a change in pull request #14: Upgrade Kotlin to v1.4

[GitBox <gi...@apache.org>]

mikaello commented on a change in pull request #14:
URL: https://github.com/apache/logging-log4j-kotlin/pull/14#discussion_r546624688



##########
File path: log4j-api-kotlin/src/test/kotlin/org.apache.logging.log4j.kotlin/LoggerTest.kt
##########
@@ -173,7 +173,8 @@ class LoggerTest {
   fun `Run in trace with result`() {
     var count = 0
     val f = withLevelFixture(Level.INFO, true) {
-      it.runInTrace(entryMsg) {
+      @SuppressWarnings("unused")
+      val mustBeHere = it.runInTrace(entryMsg) {

Review comment:
       This is not a nice solution, but I could honestly not figure out why this lambda returned `Unit` inside `runInTrace` when the return value was not stored. So to make the test pass I needed to store the return value (which is `1` , the same as it returns inside `runInTrace`).
   
   Looks like an undocumented (or at least very subtle, I tried to find any documentation) breaking change?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org