You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2023/05/02 12:35:01 UTC
[Impala-ASF-CR] IMPALA-12111: Speed up DATE materialization in coordinator
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19829
Change subject: IMPALA-12111: Speed up DATE materialization in coordinator
......................................................................
IMPALA-12111: Speed up DATE materialization in coordinator
Before this patch DATE to STRING conversion seemed slow in
general (slower than TIMESTAMP to STRING) which was problematic
mainly on the coordinator where result DATEs are returned
as STRINGs in HS2/Beeswax and the conversion happens on a
single thread.
The main cause seems to be using std::stringstream in
DateValue::ToString(). The patch switches to using
impala::TimestampParser::Format() similarly to TimestampValue.
HS2 result set generation is also changed to avoid using
stringstream for TIMESTAMP/DATE and call ToString() directly.
Benchmarks:
- Added benchmark that shows ~4x impovement for DataValue.ToString().
- Manually tested EE scanerio: RowMaterializationTimer dropped from
1.7s to 0.6s in
impala-shell -B -q "select cast(l_shipdate as date) from tpch_parquet.lineitem;" > /dev/null
Change-Id: I9a233ae92b1461fc5c47d8345667e36c2632f4c4
---
M be/src/benchmarks/date-benchmark.cc
M be/src/runtime/date-value.cc
M be/src/runtime/datetime-simple-date-format-parser.h
M be/src/runtime/raw-value.cc
M be/src/service/hs2-util.cc
5 files changed, 87 insertions(+), 29 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/19829/1
--
To view, visit http://gerrit.cloudera.org:8080/19829
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9a233ae92b1461fc5c47d8345667e36c2632f4c4
Gerrit-Change-Number: 19829
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
[Impala-ASF-CR] IMPALA-12111: Speed up DATE to STRING conversion
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Daniel Becker, Gabor Kaszab, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19829
to look at the new patch set (#4).
Change subject: IMPALA-12111: Speed up DATE to STRING conversion
......................................................................
IMPALA-12111: Speed up DATE to STRING conversion
Before this patch DATE to STRING conversion seemed slow in
general (slower than TIMESTAMP to STRING) which was visible
especially on the coordinator where result DATEs are returned
as STRINGs in HS2/Beeswax and the conversion happens on a
single thread.
The main cause seems to be using std::stringstream in
DateValue::ToString(). The patch switches to using
impala::TimestampParser::Format() similarly to TimestampValue.
HS2 result set generation is also changed to avoid using
stringstream for TIMESTAMP/DATE and call ToString() directly.
Benchmarks:
- Added benchmark that shows ~4x impovement for DateValue.ToString().
- Manually tested EE scanerio: RowMaterializationTimer dropped from
1.7s to 0.6s in
impala-shell -B -q "select cast(l_shipdate as date) from tpch_parquet.lineitem;" > /dev/null
(note that the query above converts STRING to DATE first and then
from DATE to std::string before returning it in HS2 - the
improvement comes from the second conversion)
Testing:
- ran core tests
Change-Id: I9a233ae92b1461fc5c47d8345667e36c2632f4c4
---
M be/src/benchmarks/date-benchmark.cc
M be/src/runtime/date-value.cc
M be/src/runtime/datetime-simple-date-format-parser.h
M be/src/runtime/raw-value.cc
M be/src/service/hs2-util.cc
5 files changed, 86 insertions(+), 28 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/19829/4
--
To view, visit http://gerrit.cloudera.org:8080/19829
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9a233ae92b1461fc5c47d8345667e36c2632f4c4
Gerrit-Change-Number: 19829
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-12111: Speed up DATE to STRING conversion
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19829 )
Change subject: IMPALA-12111: Speed up DATE to STRING conversion
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19829/2/be/src/benchmarks/date-benchmark.cc
File be/src/benchmarks/date-benchmark.cc:
http://gerrit.cloudera.org:8080/#/c/19829/2/be/src/benchmarks/date-benchmark.cc@244
PS2, Line 244:
> Nit: superfluous semicolon.
Done
--
To view, visit http://gerrit.cloudera.org:8080/19829
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a233ae92b1461fc5c47d8345667e36c2632f4c4
Gerrit-Change-Number: 19829
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 May 2023 09:09:45 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12111: Speed up DATE to STRING conversion
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19829 )
Change subject: IMPALA-12111: Speed up DATE to STRING conversion
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19829
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a233ae92b1461fc5c47d8345667e36c2632f4c4
Gerrit-Change-Number: 19829
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 May 2023 12:39:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12111: Speed up DATE to STRING conversion
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19829 )
Change subject: IMPALA-12111: Speed up DATE to STRING conversion
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/19829
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a233ae92b1461fc5c47d8345667e36c2632f4c4
Gerrit-Change-Number: 19829
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 May 2023 09:21:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12111: Speed up DATE to STRING conversion
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19829 )
Change subject: IMPALA-12111: Speed up DATE to STRING conversion
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19829/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19829/2//COMMIT_MSG@26
PS2, Line 26: cast(l_shipdate as date)
> HS2 returns DATE (and TIMESTAMP + DECIMAL) as string, so the cast above is
btw the actual reason for testing it like this is that there is no ~large table in the Impala test environment that has a DATE column
--
To view, visit http://gerrit.cloudera.org:8080/19829
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a233ae92b1461fc5c47d8345667e36c2632f4c4
Gerrit-Change-Number: 19829
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 May 2023 15:32:21 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12111: Speed up DATE to STRING conversion
Posted by "Kurt Deschler (Code Review)" <ge...@cloudera.org>.
Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/19829 )
Change subject: IMPALA-12111: Speed up DATE to STRING conversion
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19829/5/be/src/runtime/raw-value.cc
File be/src/runtime/raw-value.cc:
http://gerrit.cloudera.org:8080/#/c/19829/5/be/src/runtime/raw-value.cc@113
PS5, Line 113: tmp.assign(string_val->ptr, string_val->len);
tmp should have block scope here.
--
To view, visit http://gerrit.cloudera.org:8080/19829
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a233ae92b1461fc5c47d8345667e36c2632f4c4
Gerrit-Change-Number: 19829
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 May 2023 17:21:44 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12111: Speed up DATE to STRING conversion
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19829
to look at the new patch set (#2).
Change subject: IMPALA-12111: Speed up DATE to STRING conversion
......................................................................
IMPALA-12111: Speed up DATE to STRING conversion
Before this patch DATE to STRING conversion seemed slow in
general (slower than TIMESTAMP to STRING) which was visible
especially on the coordinator where result DATEs are returned
as STRINGs in HS2/Beeswax and the conversion happens on a
single thread.
The main cause seems to be using std::stringstream in
DateValue::ToString(). The patch switches to using
impala::TimestampParser::Format() similarly to TimestampValue.
HS2 result set generation is also changed to avoid using
stringstream for TIMESTAMP/DATE and call ToString() directly.
Benchmarks:
- Added benchmark that shows ~4x impovement for DataValue.ToString().
- Manually tested EE scanerio: RowMaterializationTimer dropped from
1.7s to 0.6s in
impala-shell -B -q "select cast(l_shipdate as date) from tpch_parquet.lineitem;" > /dev/null
Testing:
- ran core tests
Change-Id: I9a233ae92b1461fc5c47d8345667e36c2632f4c4
---
M be/src/benchmarks/date-benchmark.cc
M be/src/runtime/date-value.cc
M be/src/runtime/datetime-simple-date-format-parser.h
M be/src/runtime/raw-value.cc
M be/src/service/hs2-util.cc
5 files changed, 87 insertions(+), 29 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/19829/2
--
To view, visit http://gerrit.cloudera.org:8080/19829
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9a233ae92b1461fc5c47d8345667e36c2632f4c4
Gerrit-Change-Number: 19829
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-12111: Speed up DATE to STRING conversion
Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/19829 )
Change subject: IMPALA-12111: Speed up DATE to STRING conversion
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/19829/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19829/2//COMMIT_MSG@23
PS2, Line 23: DataValue
nit: typo
http://gerrit.cloudera.org:8080/#/c/19829/2//COMMIT_MSG@26
PS2, Line 26: cast(l_shipdate as date)
This is a STRING to DATE conversion while the title says the other direction. Is this direction also affected?
--
To view, visit http://gerrit.cloudera.org:8080/19829
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a233ae92b1461fc5c47d8345667e36c2632f4c4
Gerrit-Change-Number: 19829
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 May 2023 11:28:30 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12111: Speed up DATE to STRING conversion
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Daniel Becker, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19829
to look at the new patch set (#3).
Change subject: IMPALA-12111: Speed up DATE to STRING conversion
......................................................................
IMPALA-12111: Speed up DATE to STRING conversion
Before this patch DATE to STRING conversion seemed slow in
general (slower than TIMESTAMP to STRING) which was visible
especially on the coordinator where result DATEs are returned
as STRINGs in HS2/Beeswax and the conversion happens on a
single thread.
The main cause seems to be using std::stringstream in
DateValue::ToString(). The patch switches to using
impala::TimestampParser::Format() similarly to TimestampValue.
HS2 result set generation is also changed to avoid using
stringstream for TIMESTAMP/DATE and call ToString() directly.
Benchmarks:
- Added benchmark that shows ~4x impovement for DataValue.ToString().
- Manually tested EE scanerio: RowMaterializationTimer dropped from
1.7s to 0.6s in
impala-shell -B -q "select cast(l_shipdate as date) from tpch_parquet.lineitem;" > /dev/null
Testing:
- ran core tests
Change-Id: I9a233ae92b1461fc5c47d8345667e36c2632f4c4
---
M be/src/benchmarks/date-benchmark.cc
M be/src/runtime/date-value.cc
M be/src/runtime/datetime-simple-date-format-parser.h
M be/src/runtime/raw-value.cc
M be/src/service/hs2-util.cc
5 files changed, 86 insertions(+), 28 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/19829/3
--
To view, visit http://gerrit.cloudera.org:8080/19829
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9a233ae92b1461fc5c47d8345667e36c2632f4c4
Gerrit-Change-Number: 19829
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-12111: Speed up DATE to STRING conversion
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19829 )
Change subject: IMPALA-12111: Speed up DATE to STRING conversion
......................................................................
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/19829/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19829/2//COMMIT_MSG@23
PS2, Line 23: DateValue
> nit: typo
Done
http://gerrit.cloudera.org:8080/#/c/19829/2//COMMIT_MSG@26
PS2, Line 26: cast(l_shipdate as date)
> This is a STRING to DATE conversion while the title says the other directio
HS2 returns DATE (and TIMESTAMP + DECIMAL) as string, so the cast above is followed by a DateValue->std::string conversion. Before that patch the bulk of the time came for the second conversion.
Added a note about this.
--
To view, visit http://gerrit.cloudera.org:8080/19829
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a233ae92b1461fc5c47d8345667e36c2632f4c4
Gerrit-Change-Number: 19829
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 May 2023 14:47:32 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12111: Speed up DATE to STRING conversion
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19829 )
Change subject: IMPALA-12111: Speed up DATE to STRING conversion
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9288/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/19829
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a233ae92b1461fc5c47d8345667e36c2632f4c4
Gerrit-Change-Number: 19829
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 May 2023 12:39:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12111: Speed up DATE to STRING conversion
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19829 )
Change subject: IMPALA-12111: Speed up DATE to STRING conversion
......................................................................
IMPALA-12111: Speed up DATE to STRING conversion
Before this patch DATE to STRING conversion seemed slow in
general (slower than TIMESTAMP to STRING) which was visible
especially on the coordinator where result DATEs are returned
as STRINGs in HS2/Beeswax and the conversion happens on a
single thread.
The main cause seems to be using std::stringstream in
DateValue::ToString(). The patch switches to using
impala::TimestampParser::Format() similarly to TimestampValue.
HS2 result set generation is also changed to avoid using
stringstream for TIMESTAMP/DATE and call ToString() directly.
Benchmarks:
- Added benchmark that shows ~4x impovement for DateValue.ToString().
- Manually tested EE scanerio: RowMaterializationTimer dropped from
1.7s to 0.6s in
impala-shell -B -q "select cast(l_shipdate as date) from tpch_parquet.lineitem;" > /dev/null
(note that the query above converts STRING to DATE first and then
from DATE to std::string before returning it in HS2 - the
improvement comes from the second conversion)
Testing:
- ran core tests
Change-Id: I9a233ae92b1461fc5c47d8345667e36c2632f4c4
Reviewed-on: http://gerrit.cloudera.org:8080/19829
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/benchmarks/date-benchmark.cc
M be/src/runtime/date-value.cc
M be/src/runtime/datetime-simple-date-format-parser.h
M be/src/runtime/raw-value.cc
M be/src/service/hs2-util.cc
5 files changed, 86 insertions(+), 28 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/19829
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9a233ae92b1461fc5c47d8345667e36c2632f4c4
Gerrit-Change-Number: 19829
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
[Impala-ASF-CR] IMPALA-12111: Speed up DATE to STRING conversion
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19829 )
Change subject: IMPALA-12111: Speed up DATE to STRING conversion
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19829
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a233ae92b1461fc5c47d8345667e36c2632f4c4
Gerrit-Change-Number: 19829
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 May 2023 12:39:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12111: Speed up DATE to STRING conversion
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19829 )
Change subject: IMPALA-12111: Speed up DATE to STRING conversion
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12907/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19829
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a233ae92b1461fc5c47d8345667e36c2632f4c4
Gerrit-Change-Number: 19829
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 May 2023 12:55:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12111: Speed up DATE to STRING conversion
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19829 )
Change subject: IMPALA-12111: Speed up DATE to STRING conversion
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Looks good, thanks.
http://gerrit.cloudera.org:8080/#/c/19829/2/be/src/benchmarks/date-benchmark.cc
File be/src/benchmarks/date-benchmark.cc:
http://gerrit.cloudera.org:8080/#/c/19829/2/be/src/benchmarks/date-benchmark.cc@244
PS2, Line 244: ;
Nit: superfluous semicolon.
--
To view, visit http://gerrit.cloudera.org:8080/19829
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a233ae92b1461fc5c47d8345667e36c2632f4c4
Gerrit-Change-Number: 19829
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 May 2023 08:51:17 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12111: Speed up DATE to STRING conversion
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19829 )
Change subject: IMPALA-12111: Speed up DATE to STRING conversion
......................................................................
Patch Set 4: Code-Review+1
In some basic tests that use a big table with a single date column, this reduces RowMaterializationTime significantly:
Date before: RowMaterializationRate: 2.28 M/sec
Date after: RowMaterializationRate: 13.56 M/sec
It also helps on timestamp (using a similar table with a single timestamp column):
Timestamp before: RowMaterializationRate: 3.15 M/sec
Timestamp after: RowMaterializationRate: 8.55 M/sec
This makes sense to me.
--
To view, visit http://gerrit.cloudera.org:8080/19829
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a233ae92b1461fc5c47d8345667e36c2632f4c4
Gerrit-Change-Number: 19829
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 May 2023 00:47:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12111: Speed up DATE to STRING conversion
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19829 )
Change subject: IMPALA-12111: Speed up DATE to STRING conversion
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19829
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a233ae92b1461fc5c47d8345667e36c2632f4c4
Gerrit-Change-Number: 19829
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 May 2023 17:52:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12111: Speed up DATE to STRING conversion
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19829 )
Change subject: IMPALA-12111: Speed up DATE to STRING conversion
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12913/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19829
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a233ae92b1461fc5c47d8345667e36c2632f4c4
Gerrit-Change-Number: 19829
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 May 2023 09:30:13 +0000
Gerrit-HasComments: No