You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Emond Papegaaij (JIRA)" <ji...@apache.org> on 2011/01/25 14:36:51 UTC

[jira] Updated: (WICKET-3383) Strange writeObjectMethodCache in SerializableChecker

     [ https://issues.apache.org/jira/browse/WICKET-3383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emond Papegaaij updated WICKET-3383:
------------------------------------

    Attachment: wicket-3383.diff

> Strange writeObjectMethodCache in SerializableChecker
> -----------------------------------------------------
>
>                 Key: WICKET-3383
>                 URL: https://issues.apache.org/jira/browse/WICKET-3383
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.15
>            Reporter: Emond Papegaaij
>            Priority: Minor
>         Attachments: wicket-3383.diff
>
>
> At Topicus, we maintain a customized SerializableChecker with some additional 
> checks. I was trying to fix some generics-warnings and noticed a strange thing 
> about the writeObjectMethodCache. This variable is used in only 4 places, one 
> is a clear, one a get and 2 are puts. Both puts take a Boolean as value, but 
> the get checks if the value returned is a Method, which obviously can never 
> happen. I think the 'writeObjectMethod' should be put into the map after line 
> 473:
>         writeObjectMethod = cls.getDeclaredMethod("writeObject",
>                         new Class[] { java.io.ObjectOutputStream.class });

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.