You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/04/21 17:24:03 UTC

[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #5377: [HUDI-3935] Adding config to fallback to enabled Partition Values extraction from Partition path

alexeykudinkin commented on code in PR #5377:
URL: https://github.com/apache/hudi/pull/5377#discussion_r855420115


##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala:
##########
@@ -774,4 +785,23 @@ object DataSourceOptionsHelper {
       override def apply (input: From): To = function (input)
     }
   }
+
+  implicit def convert[T, U](prop: ConfigProperty[T])(implicit converter: T => U): ConfigProperty[U] = {
+    checkState(prop.hasDefaultValue)

Review Comment:
   If this will break it will break when the class is loaded, meaning that all the tests using class would be broken, which is very easy to diagnose



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org