Re: [PR] Enable configurable display of partition sizes in the explain statement [arrow-datafusion]

["mustafasrepo (via GitHub)" <gi...@apache.org>]

mustafasrepo commented on code in PR #9474:
URL: https://github.com/apache/arrow-datafusion/pull/9474#discussion_r1514385075


##########
datafusion/physical-plan/src/memory.rs:
##########
@@ -151,6 +157,15 @@ impl MemoryExec {
         partitions: &[Vec<RecordBatch>],
         schema: SchemaRef,
         projection: Option<Vec<usize>>,
+    ) -> Result<Self> {
+        Self::try_new_with_show_sizes(partitions, schema, projection, true)
+    }
+
+    pub fn try_new_with_show_sizes(

Review Comment:
   I think, instead of this API. You can use builder API such as below
   ```rust
   pub fn with_show_sizes(mut self, show_sizes: bool) -> Self{
       self.show_sizes = show_sizes;
   }
   ```
   However, this is purely stylistic. Feel free to proceed as you wish.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org