[jira] [Commented] (HBASE-13470) High level Integration test for master DDL operations

["Matteo Bertozzi (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-13470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14504495#comment-14504495 ] 

Matteo Bertozzi commented on HBASE-13470:
-----------------------------------------

looks great, thanks [~fengs]!
can you put it on reviewboard so it is easier to review?

from a quick look there are just two things I noticed.
 - you consider every operation able to complete successfully. but this is more or less true only in case of delete/disable (delete at least can fail if waiting for region in transition takes longer then the timeout). anyway, what I'm saying is that you may get false positives if any operation hit an exception e.g. hdfs/zk not responding or similar. in theory you can just put a for loop around the admin.operation() and retry N times, if you get an exception, before asserting.
 - the assert in the modify/add-family operations doesn't look right. you fetch the descriptor in the beginning, you modify it and assert on that descriptor not a new one fetched from the master.

> High level Integration test for master DDL operations
> -----------------------------------------------------
>
>                 Key: HBASE-13470
>                 URL: https://issues.apache.org/jira/browse/HBASE-13470
>             Project: HBase
>          Issue Type: Sub-task
>          Components: master
>            Reporter: Enis Soztutar
>             Fix For: 2.0.0, 1.1.0
>
>         Attachments: HBASE-13470-v0.patch
>
>
> Our [~fengs] has an integration test which executes DDL operations with a new monkey to kill the active master as a high level test for the proc v2 changes. 
> The test does random DDL operations from 20 client threads. The DDL statements are create / delete / modify / enable / disable table and CF operations. It runs HBCK to verify the end state. 
> The test can be run on a single master, or multi master setup. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)