You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/03 10:51:19 UTC

[GitHub] [airflow] khalidmammadov commented on a change in pull request #20625: Fxing MyPy issues inside airflow/providers/qubole

khalidmammadov commented on a change in pull request #20625:
URL: https://github.com/apache/airflow/pull/20625#discussion_r777406294



##########
File path: airflow/providers/qubole/operators/qubole.py
##########
@@ -217,7 +217,7 @@ class QuboleOperator(BaseOperator):
         'cluster_label',
     )
 
-    template_ext: Iterable[str] = ('.txt',)
+    template_ext: Sequence[str] = ('.txt',)

Review comment:
       This field is defined in the base class as `Sequence`. It used to be `Iterable` and was changed [here](https://github.com/apache/airflow/commit/59e4b78daa3496cb0358ce34aeb5ebf6f5565ce0#diff-848f325ace55b3504e8052fecdb53c0f295c891b67a6d90e9341cbe79cc545fbR428). I changed it to match base class and not sure if order here metters at all. BTW, it was suggested by you :) https://github.com/apache/airflow/pull/20034#discussion_r762426218




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org