You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/05/10 15:50:07 UTC
[GitHub] [hive] kasakrisz opened a new pull request, #3277: Hive 21160 rewrite update to multiinsert refactor
kasakrisz opened a new pull request, #3277:
URL: https://github.com/apache/hive/pull/3277
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kasakrisz commented on pull request #3277: Hive 21160 rewrite update to multiinsert refactor
Posted by GitBox <gi...@apache.org>.
kasakrisz commented on PR #3277:
URL: https://github.com/apache/hive/pull/3277#issuecomment-1154057614
Comments are addressed by #2855
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kasakrisz closed pull request #3277: Hive 21160 rewrite update to multiinsert refactor
Posted by GitBox <gi...@apache.org>.
kasakrisz closed pull request #3277: Hive 21160 rewrite update to multiinsert refactor
URL: https://github.com/apache/hive/pull/3277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a diff in pull request #3277: Hive 21160 rewrite update to multiinsert refactor
Posted by GitBox <gi...@apache.org>.
pvary commented on code in PR #3277:
URL: https://github.com/apache/hive/pull/3277#discussion_r880146433
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java:
##########
@@ -23,6 +23,8 @@
import java.util.HashMap;
import java.util.List;
import java.util.Map;
+import java.util.stream.Collectors;
Review Comment:
nit: not needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a diff in pull request #3277: Hive 21160 rewrite update to multiinsert refactor
Posted by GitBox <gi...@apache.org>.
pvary commented on code in PR #3277:
URL: https://github.com/apache/hive/pull/3277#discussion_r880145361
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergInputFormat.java:
##########
@@ -511,24 +515,11 @@ private static Schema readSchema(Configuration conf, Table table, boolean caseSe
readSchema = caseSensitive ? table.schema().select(selectedColumns) :
table.schema().caseInsensitiveSelect(selectedColumns);
- Operation operation = HiveIcebergStorageHandler.operation(conf, conf.get(Catalogs.NAME));
- if (operation != null) {
- switch (operation) {
- case DELETE:
- // for DELETE queries, add additional metadata columns into the read schema
- return IcebergAcidUtil.createFileReadSchemaForDelete(readSchema.columns(), table);
- case UPDATE:
- // for UPDATE queries, add additional metadata columns into the read schema
- return IcebergAcidUtil.createFileReadSchemaForUpdate(readSchema.columns(), table);
- case OTHER:
- // for INSERT queries no extra columns are needed
- return readSchema;
- default:
- throw new IllegalArgumentException("Not supported operation " + operation);
- }
- } else {
- return readSchema;
+ if (InputFormatConfig.fetchVirtualColumns(conf)) {
+ return IcebergAcidUtil.createFileReadSchemaForDelete(readSchema.columns(), table);
Review Comment:
Maybe rename the method to `createFileReadSchemaWithVirtualColums`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a diff in pull request #3277: Hive 21160 rewrite update to multiinsert refactor
Posted by GitBox <gi...@apache.org>.
pvary commented on code in PR #3277:
URL: https://github.com/apache/hive/pull/3277#discussion_r880148379
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##########
@@ -11484,14 +11484,13 @@ private Operator genTablePlan(String alias, QB qb) throws SemanticException {
}
// put all virtual columns in RowResolver.
- if (!tab.isNonNative()) {
- for (VirtualColumn vc : VirtualColumn.getRegistry(conf)) {
- vcList.add(vc);
- rwsch.put(alias, vc.getName().toLowerCase(), new ColumnInfo(vc.getName(),
- vc.getTypeInfo(), alias, true, vc.getIsHidden()
- ));
- }
+ vcList = VirtualColumn.getRegistry(conf);
Review Comment:
nit: The `vcList` has been declared previously. We are redefining it. Is it ok? Shall we just use another variable, to make sure no collision happens?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a diff in pull request #3277: Hive 21160 rewrite update to multiinsert refactor
Posted by GitBox <gi...@apache.org>.
pvary commented on code in PR #3277:
URL: https://github.com/apache/hive/pull/3277#discussion_r880144671
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/InputFormatConfig.java:
##########
@@ -235,6 +236,10 @@ public static String[] selectedColumns(Configuration conf) {
return readColumns.split(conf.get(serdeConstants.COLUMN_NAME_DELIMITER, String.valueOf(SerDeUtils.COMMA)));
}
+ public static boolean fetchVirtualColumns(Configuration conf) {
Review Comment:
Should we store this on table level, instead of globally?
If there is a query reading an iceberg table, and deleting from another table, then we do not need to read the virtual columns for the table we are just reading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a diff in pull request #3277: Hive 21160 rewrite update to multiinsert refactor
Posted by GitBox <gi...@apache.org>.
pvary commented on code in PR #3277:
URL: https://github.com/apache/hive/pull/3277#discussion_r880146139
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/MapOperator.java:
##########
@@ -28,6 +28,7 @@
import java.util.Map.Entry;
import java.util.Properties;
import java.util.Set;
+import java.util.stream.Collectors;
Review Comment:
nit: not needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org