You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by pedro surf <pe...@gmail.com> on 2009/02/12 14:53:15 UTC
Changing manifest task to accept classpath by reference and nested
element!
Hi everybody,
this is my first e-mail do this list. Recently I had to create a jar file
with a classpath in the manifest file. The classpath of my project was
defined as a nested element but the manifest task only accept it as a value
in the attribute element. I had to use a manifestclasspath task to convert
the classpath to a property and then use its value.
I believe changing the manifest task to accept a classpathref as a parameter
or a nested element would be a great change that would increase the
readability of the build and reduce the amount of code necessary to do a
simple (and usual) task.
I don´t know if this change is already in the plans of the ant team, but if
not I would like to do it. However I´ve never worked in a open source
project, so any help (best practices, code reviews, ...) would be great.
Cheers,
Pedro
Re: Changing manifest task to accept classpath by reference and nested element!
Posted by Stefan Bodewig <bo...@apache.org>.
On 2009-02-12, pedro surf <pe...@gmail.com> wrote:
> I believe changing the manifest task to accept a classpathref as a
> parameter or a nested element would be a great change that would
> increase the readability of the build and reduce the amount of code
> necessary to do a simple (and usual) task.
I'd probably go for a nested element and allow it to be an arbitrary
file system based resource collection instead of a reference to a path
- that way you coud even define the classpath inline if you don't need
it anywhere else.
> I don´t know if this change is already in the plans of the ant team,
Not that I was aware of it.
> but if not I would like to do it. However I´ve never worked in a
> open source project, so any help (best practices, code reviews, ...)
> would be great.
Different projects take different approaches.
The one I think has worked best for Ant is to discuss the feature
itself, potentially including some implementation details, on this
list. And when it is time to actually write code you open an
enhancement request in Bugzilla and attach your changes as a patch
(unified diff or "svn diff" against the current Subversion trunk of
Ant preferred).
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org