You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pdfbox.apache.org by "Tilman Hausherr (JIRA)" <ji...@apache.org> on 2018/06/13 17:23:00 UTC
[jira] [Comment Edited] (PDFBOX-3000) Transparency Group issues
[ https://issues.apache.org/jira/browse/PDFBOX-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16511442#comment-16511442 ]
Tilman Hausherr edited comment on PDFBOX-3000 at 6/13/18 5:22 PM:
------------------------------------------------------------------
Thank you...
PDFJS-6961.pdf never finishes (or takes extremently long), this is from here:
https://github.com/mozilla/pdf.js/issues/6961
I suspect that the discussion there also applies to the problem here...
I'm surprised that the rendering of gs-bugzilla697425.pdf is better. I wonder whether the change from february wasn't enough, that one just checked whether the immediate resources has a blendmode. I see that in PageDrawer, you check recursively. Btw I wonder if we should check tiling patterns as well, i.e. whether they have transparency groups inside their resources...
Could you please add some comment on top of the GroupGraphics class (maybe similar to your text here) and a few comments in removeBackdrop() that summarize what's being done? I'm aware that the current consensus is that the code should speak for itself, and I usually agree with that, but here we're dealing with very complex matters (at least for me, because I'm not a graphics developer).
I haven't had the time to review all the rendering changes, this will take some time. The code change won't be part of 2.0.10 (due next week), but in 2.0.11 (if it is good, and I assume it is).
was (Author: tilman):
Thank you...
PDFJS-6961.pdf never finishes (or takes extremently long), this is from here:
https://github.com/mozilla/pdf.js/issues/6961
I suspect that the discussion there also applies to the problem here...
I'm surprised that the rendering of gs-bugzilla697425.pdf is better. I wonder whether the change from february wasn't enough, that one just checked whether the immediate resources has a blendmode. I see that in PageDrawer, you check recursively. Btw I wonder if we should check tiling patterns as well, i.e. whether they have transparency groups inside their resources...
Could you please add some comment on top of the GroupGraphics class (maybe similar to your text here) and a few comments in removeBackdrop() that summarize what's being done? I'm aware that the current consensus is that the code should speak for itself, and I usually agree with that, but here we're dealing with very complex matters (at least for me, because I'm not a graphics developer).
I haven't had the time to review all the rendering changes, this will take some time. The code change won't be part of 2.0.10 (due next week), but in 2.0.11 (if it is good, and I assume it is).
> Transparency Group issues
> -------------------------
>
> Key: PDFBOX-3000
> URL: https://issues.apache.org/jira/browse/PDFBOX-3000
> Project: PDFBox
> Issue Type: Bug
> Components: Rendering
> Affects Versions: 2.0.0
> Reporter: John Hewson
> Priority: Major
> Labels: Transparency
> Fix For: 3.0.0 PDFBox
>
> Attachments: 007087-payment-due-p58_reduced2.pdf, BlendModes-rgb.pdf, PDFBOX-1697-reduced-rotations.pdf, PDFBOX-2182_mod.pdf, PDFBOX-3400-RGB.pdf, PDFBOX-3494_reduced.pdf, PDFBOX-3494_reduced_cropX.pdf, PDFBOX-3564-Mask.pdf, PDFBox3359PanelTestEnhanced.java, PDFJS-2845-p1.pdf, PDFJS-5526-p13_reduced1.pdf, PDFJS-5526-p13_reduced2.pdf, PDFJS-5526-p13_reduced3-nogroup.pdf, PDFJS-5811-2-p3_reduced.pdf, PDFJS-5811-2-p3_reduced4.pdf, PDFJS-5811-2-p4_reduced-rotations.pdf, PDFJS-5811-2.pdf, PDFJS-5853_reduced.pdf, PDFJS-6961.pdf, PDFJS-6967-p8.pdf, PDFJS-6967_reduced_outside_softmask.pdf, PDFJS-8136-p1.pdf, PDFJS-8136-p1_reduced.pdf, SoftMask-Clipped.pdf, SoftMask.pdf, blendmodes.pdf, circle-simple.pdf, ds-firewall-enterprise-p1_reduced.pdf, gs-bugzilla689309-reduced-bc0.pdf, gs-bugzilla689309-reduced-bc1.pdf, gs-bugzilla689309-reduced.pdf, gs-bugzilla689931_reduced-Multiply.pdf, gs-bugzilla689931_reduced-Screen.pdf, gs-bugzilla689931_reduced-ScreenBlendPageBackground.pdf, gs-bugzilla690022-reduced-rotations-cropbox.pdf, gs-bugzilla690022-reduced-rotations.pdf, gs-bugzilla690022_reduced.pdf, gs-bugzilla691157.pdf, gs-bugzilla691157_mod_unc.pdf, gs-bugzilla691157_mod_unc.png, gs-bugzilla691348.pdf, gs-bugzilla691650-2.pdf, gs-bugzilla692217_reduced.pdf, gs-bugzilla693134-giant-pattern-reduced.pdf, gs-bugzilla693322_reduced.pdf, gs-bugzilla694556-3.pdf, gs-bugzilla695354.pdf, gs-bugzilla695582-transparency-fill-stroke.pdf, gs-bugzilla695582-transparency-fill-stroke.pdf-1.png, gs-bugzilla697425.pdf, isolation.pdf, nonisolated_groups_patch.zip, pop-bugzilla40164.pdf, samsung_galaxy_s_4_um-p1_reduced.pdf, snowman-nose-gradient-rgb.pdf, snowman-nose-gradient-rgb_reduced-0.6-bad2.pdf, snowman-nose-gradient-rgb_reduced-0.7-good2.pdf, snowman-nose-gradient-screenshot-comparison-11.12.2016.jpg, snowman-nose-gradient.pdf, snowmen-opacity-clipping-masks-2.0.3.png, snowmen-opacity-clipping-masks-2.1-SNAPSHOT-10.12.2016.png, snowmen-opacity-clipping-masks-2.1.0-SNAPSHOT-2016-12-07.png, snowmen-opacity-clipping-masks-adobe-illustrator.png, snowmen-opacity-clipping-masks.pdf, softmask-rewrite-alt1.patch, softmask-rewrite.patch
>
>
> This is a follow-up issue for transparency group issues from PDFBOX-2423. More details to come.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org