You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@parquet.apache.org by "iemejia (via GitHub)" <gi...@apache.org> on 2026/09/01 07:46:03 UTC
Re: [PR] Upgrade Avro dependency from 1.11.5 to 1.12.2 [parquet-java]
iemejia commented on code in PR #3731:
URL: https://github.com/apache/parquet-java/pull/3731#discussion_r3901898450
##########
parquet-avro/src/main/java/org/apache/parquet/avro/AvroRecordConverter.java:
##########
@@ -355,7 +355,7 @@ private static Converter newConverter(
LogicalType logicalType = schema.getLogicalType();
Conversion<?> conversion;
- if (knownClass != null) {
+ if (knownClass != null && logicalType != null) {
Review Comment:
Good catch — this change wasn't actually necessary. As Ryan noted, it's no longer needed thanks to [AVRO-4321](https://issues.apache.org/jira/browse/AVRO-4321). I've reverted this line back to the original. Thanks!
##########
parquet-avro/src/main/java/org/apache/parquet/avro/AvroRecordConverter.java:
##########
@@ -355,7 +355,7 @@ private static Converter newConverter(
LogicalType logicalType = schema.getLogicalType();
Conversion<?> conversion;
- if (knownClass != null) {
+ if (knownClass != null && logicalType != null) {
Review Comment:
Reverted, thanks! Confirmed the `parquet-avro` test suite passes (408 tests) with Avro 1.12.2 without this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org