You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/07/02 17:10:08 UTC
[GitHub] codecov-io commented on issue #3830: Include rotating user log
filename in system logs
codecov-io commented on issue #3830: Include rotating user log filename in system logs
URL: https://github.com/apache/incubator-openwhisk/pull/3830#issuecomment-401871972
# [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3830?src=pr&el=h1) Report
> Merging [#3830](https://codecov.io/gh/apache/incubator-openwhisk/pull/3830?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/cd91b4fc024b16b9cc89b1aef77deb494da939e2?src=pr&el=desc) will **increase** coverage by `0.84%`.
> The diff coverage is `25%`.
[](https://codecov.io/gh/apache/incubator-openwhisk/pull/3830?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3830 +/- ##
==========================================
+ Coverage 73.87% 74.72% +0.84%
==========================================
Files 138 138
Lines 6446 6449 +3
Branches 401 394 -7
==========================================
+ Hits 4762 4819 +57
+ Misses 1684 1630 -54
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3830?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rpool/logging/DockerToActivationFileLogStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3830/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9sb2dnaW5nL0RvY2tlclRvQWN0aXZhdGlvbkZpbGVMb2dTdG9yZS5zY2FsYQ==) | `75% <25%> (-3.38%)` | :arrow_down: |
| [...cala/src/main/scala/whisk/http/ErrorResponse.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3830/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2h0dHAvRXJyb3JSZXNwb25zZS5zY2FsYQ==) | `89.77% <0%> (+1.13%)` | :arrow_up: |
| [...ain/scala/whisk/core/entity/ActivationResult.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3830/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0FjdGl2YXRpb25SZXN1bHQuc2NhbGE=) | `92.3% <0%> (+1.53%)` | :arrow_up: |
| [...in/scala/whisk/utils/ExecutionContextFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3830/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL3V0aWxzL0V4ZWN1dGlvbkNvbnRleHRGYWN0b3J5LnNjYWxh) | `100% <0%> (+7.69%)` | :arrow_up: |
| [...rc/main/scala/whisk/core/entity/ExecManifest.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3830/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0V4ZWNNYW5pZmVzdC5zY2FsYQ==) | `96.29% <0%> (+14.81%)` | :arrow_up: |
| [...whisk/connector/kafka/KafkaConsumerConnector.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3830/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYWZrYUNvbnN1bWVyQ29ubmVjdG9yLnNjYWxh) | `62.96% <0%> (+29.62%)` | :arrow_up: |
| [...whisk/connector/kafka/KafkaProducerConnector.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3830/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYWZrYVByb2R1Y2VyQ29ubmVjdG9yLnNjYWxh) | `58.33% <0%> (+36.11%)` | :arrow_up: |
| [...whisk/connector/kafka/KafkaMessagingProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3830/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYWZrYU1lc3NhZ2luZ1Byb3ZpZGVyLnNjYWxh) | `69.23% <0%> (+46.15%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3830?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3830?src=pr&el=footer). Last update [cd91b4f...9a744f2](https://codecov.io/gh/apache/incubator-openwhisk/pull/3830?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services