[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #10526: fb: add vsync queue mechanism

["pkarashchenko (via GitHub)" <gi...@apache.org>]

pkarashchenko commented on code in PR #10526:
URL: https://github.com/apache/nuttx/pull/10526#discussion_r1327639494


##########
arch/sim/src/sim/sim_framebuffer.c:
##########
@@ -455,9 +462,12 @@ int up_fbinitialize(int display)
   int ret = OK;
 
 #ifdef CONFIG_SIM_X11FB
+  g_planeinfo.xres_virtual = CONFIG_SIM_FBWIDTH;
+  g_planeinfo.yres_virtual = CONFIG_SIM_FBHEIGHT * CONFIG_SIM_FRAMEBUFFER_COUNT;

Review Comment:
   Good to fix this



##########
drivers/video/fb.c:
##########
@@ -41,17 +41,30 @@
 #include <nuttx/video/fb.h>
 #include <nuttx/clock.h>
 #include <nuttx/wdog.h>
+#include <nuttx/mm/circbuf.h>
 
 /****************************************************************************
  * Pre-processor definitions
  ****************************************************************************/
 
-#define FB_NO_OVERLAY -1
-
 /****************************************************************************
  * Private Types
  ****************************************************************************/
 
+struct fb_priv_s
+{
+  int overlay;                    /* Overlay number */
+};
+
+struct fb_paninfo_s
+{
+  FAR struct circbuf_s buf;       /* Pan buffer queued list */

Review Comment:
   `FAR` is not needed here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org