You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "darkSheep404 (via GitHub)" <gi...@apache.org> on 2023/02/22 12:09:46 UTC
[GitHub] [apisix] darkSheep404 opened a new pull request, #8912: docs:checkout branch after clone apisix-docker
darkSheep404 opened a new pull request, #8912:
URL: https://github.com/apache/apisix/pull/8912
### Description
<!-- Please include a summary of the change and which issue is fixed. -->
<!-- Please also include relevant motivation and context. -->
Fixes # (issue)
fix issue:https://github.com/apache/apisix-docker/issues/434
the admin port was changed to 9180 after version upgrate
if don't checkout branches,clone apisix-docker and start docker directly,
when run command like in docs of current version
will return {"error_msg":"404 Route Not Found"}
which leads to confusion for people who select docs of current LTS version (2.15) to learn
for exmaple
```
# 注意：请在运行 Docker 的宿主机上执行 curl 命令。
curl "http://127.0.0.1:9080/apisix/admin/services/" -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1'
``
### Checklist
- [x] I have explained the need for this PR and the problem it solves
- [x] I have explained the changes or the new features added to this PR
- [x] I have added tests corresponding to this change
- [x] I have updated the documentation to reflect this change
- [x] ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a diff in pull request #8912: docs: update docs for LTS v2.15: checkout branch to release/2.15 after clone apisix-docker to avoid 404 Route Not Found caused by admin port changed in default branch
Posted by "juzhiyuan (via GitHub)" <gi...@apache.org>.
juzhiyuan commented on code in PR #8912:
URL: https://github.com/apache/apisix/pull/8912#discussion_r1115163859
##########
docs/en/latest/getting-started.md:
##########
@@ -125,6 +125,7 @@ First clone the [apisix-docker](https://github.com/apache/apisix-docker) reposit
```shell
git clone https://github.com/apache/apisix-docker.git
+git checkout release/2.15
Review Comment:
Hi @darkSheep404, the Getting Started part will be replaced by https://docs.api7.ai/apisix/documentation. You can refer to these docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] darkSheep404 commented on a diff in pull request #8912: docs: update docs for LTS v2.15: checkout branch to release/2.15 after clone apisix-docker to avoid 404 Route Not Found caused by admin port changed in default branch
Posted by "darkSheep404 (via GitHub)" <gi...@apache.org>.
darkSheep404 commented on code in PR #8912:
URL: https://github.com/apache/apisix/pull/8912#discussion_r1115167937
##########
docs/en/latest/getting-started.md:
##########
@@ -125,6 +125,7 @@ First clone the [apisix-docker](https://github.com/apache/apisix-docker) reposit
```shell
git clone https://github.com/apache/apisix-docker.git
+git checkout release/2.15
Review Comment:
hi @juzhiyuan thank you for provide new docs😃
but due to the current search result of apisix docs,i think this enhancement to this LTS version will do helps to learner like me too 😃
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a diff in pull request #8912: docs: update docs for LTS v2.15: checkout branch to release/2.15 after clone apisix-docker to avoid 404 Route Not Found caused by admin port changed in default branch
Posted by "juzhiyuan (via GitHub)" <gi...@apache.org>.
juzhiyuan commented on code in PR #8912:
URL: https://github.com/apache/apisix/pull/8912#discussion_r1115282103
##########
docs/en/latest/getting-started.md:
##########
@@ -125,6 +125,7 @@ First clone the [apisix-docker](https://github.com/apache/apisix-docker) reposit
```shell
git clone https://github.com/apache/apisix-docker.git
+git checkout release/2.15
Review Comment:
RIght. But I plan to submit another PR to update the contents totally. (Replace Getting Started in apisix.apache.org) Is it ok for you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] darkSheep404 closed pull request #8912: docs: update docs for LTS v2.15: checkout branch to release/2.15 after clone apisix-docker to avoid 404 Route Not Found caused by admin port changed in default branch
Posted by "darkSheep404 (via GitHub)" <gi...@apache.org>.
darkSheep404 closed pull request #8912: docs: update docs for LTS v2.15: checkout branch to release/2.15 after clone apisix-docker to avoid 404 Route Not Found caused by admin port changed in default branch
URL: https://github.com/apache/apisix/pull/8912
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] darkSheep404 commented on a diff in pull request #8912: docs: update docs for LTS v2.15: checkout branch to release/2.15 after clone apisix-docker to avoid 404 Route Not Found caused by admin port changed in default branch
Posted by "darkSheep404 (via GitHub)" <gi...@apache.org>.
darkSheep404 commented on code in PR #8912:
URL: https://github.com/apache/apisix/pull/8912#discussion_r1115334638
##########
docs/en/latest/getting-started.md:
##########
@@ -125,6 +125,7 @@ First clone the [apisix-docker](https://github.com/apache/apisix-docker) reposit
```shell
git clone https://github.com/apache/apisix-docker.git
+git checkout release/2.15
Review Comment:
That would be great if you did that😀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org