[GitHub] [spark] kevin85421 commented on a diff in pull request #37384: [SPARK-39955][CORE] Improve LaunchTask process to avoid Stage failures caused by fail-to-send LaunchTask messages

[GitBox <gi...@apache.org>]

kevin85421 commented on code in PR #37384:
URL: https://github.com/apache/spark/pull/37384#discussion_r943141768


##########
core/src/main/scala/org/apache/spark/scheduler/TaskInfo.scala:
##########
@@ -108,6 +110,10 @@ class TaskInfo(
     }
   }
 
+  private[spark] def launchSucceeded: Unit = {

Review Comment:
   Updated.



##########
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala:
##########
@@ -1067,11 +1067,14 @@ private[spark] class TaskSetManager(
       }
     }
     for ((tid, info) <- taskInfos if info.running && info.executorId == execId) {
+      // If the task is launching, this indicates that Driver has sent LaunchTask to Executor,
+      // but Executor has not sent StatusUpdate(TaskState.RUNNING) to Driver. Hence, we assume that
+      // the task is not running, and it is NetworkFailure rather than TaskFailure.

Review Comment:
   Updated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org