You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cordova.apache.org by "Close, Rob" <ro...@sap.com> on 2016/06/07 20:02:30 UTC

New whitelist jira issue and merge request

Hi,

The Jira issue: https://issues.apache.org/jira/browse/CB-11391
Merge request: https://github.com/apache/cordova-plugin-whitelist/pull/20

Summary: Source is not passing sonarqube scan.

Thanks,
Rob.

New whitelist jira issue and merge request

Posted by "Close, Rob" <ro...@sap.com>.

Hi,

The Jira issue: https://issues.apache.org/jira/browse/CB-11391
Merge request: https://github.com/apache/cordova-plugin-whitelist/pull/21

Summary:
With my previous change “Source is not passing sonarqube scan”
I failed to notice that there are three states: true, false, or null.  (I was only expecting true and false.  Maybe an enumeration would better than a Boolean in this case?)
Sorry for the mix up.


Thanks,
Rob.

RE: New whitelist jira issue and merge request

Posted by "Vladimir Kotikov (Akvelon)" <v-...@microsoft.com>.

I have merged these PRs:
https://github.com/apache/cordova-plugin-inappbrowser/pull/169
https://github.com/apache/cordova-plugin-file/pull/183
https://github.com/apache/cordova-plugin-whitelist/pull/20

-
Best regards, Vladimir

-----Original Message-----
From: Joe Bowser [mailto:bowserj@gmail.com] 
Sent: Tuesday, June 7, 2016 11:07 PM
To: dev <de...@cordova.apache.org>
Subject: Re: New whitelist jira issue and merge request

Please stop sending the same email with a slightly modified header.  We did receive this pull request, and someone will look at it when they are available.

Thanks
Joe

On Tue, Jun 7, 2016 at 1:02 PM, Close, Rob <ro...@sap.com> wrote:

> Hi,
>
> The Jira issue: 
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissue
> s.apache.org%2fjira%2fbrowse%2fCB-11391&data=01%7c01%7cv-vlkoti%40micr
> osoft.com%7c1831dde883f949dc99eb08d38f0f4899%7c72f988bf86f141af91ab2d7
> cd011db47%7c1&sdata=JLRvhd9NyUw7X%2beD4Q13UqNVY2ORWkMWoDx98nFuc5o%3d
> Merge request: 
> https://github.com/apache/cordova-plugin-whitelist/pull/20
>
> Summary: Source is not passing sonarqube scan.
>
> Thanks,
> Rob.
>

Re: New whitelist jira issue and merge request

Posted by Joe Bowser <bo...@gmail.com>.

Please stop sending the same email with a slightly modified header.  We did
receive this pull request, and someone will look at it when they are
available.

Thanks
Joe

On Tue, Jun 7, 2016 at 1:02 PM, Close, Rob <ro...@sap.com> wrote:

> Hi,
>
> The Jira issue: https://issues.apache.org/jira/browse/CB-11391
> Merge request: https://github.com/apache/cordova-plugin-whitelist/pull/20
>
> Summary: Source is not passing sonarqube scan.
>
> Thanks,
> Rob.
>