You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by "weizhouapache (via GitHub)" <gi...@apache.org> on 2026/09/07 07:23:02 UTC

Re: [PR] server: null-check public IP before the DNS/Source NAT guard in create [cloudstack]

weizhouapache commented on PR #14027:
URL: https://github.com/apache/cloudstack/pull/14027#issuecomment-5566724382

   please ignore my previous approval
   
   - We have never encountered an NPE caused by this line of code.
   
   - I suggest throwing an exception if the ipVO object is null.
   
   cc @DaanHoogland 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org