You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/08/28 22:00:15 UTC

[GitHub] [iceberg] stevenzwu commented on pull request #1185: Flink: Add the iceberg files committer to collect data files and commit to iceberg table.

stevenzwu commented on pull request #1185:
URL: https://github.com/apache/iceberg/pull/1185#issuecomment-683164685


   nit: on class names
   
   IcebergStreamWriter -> IcebergWriter, because it also BoundedOneInput interface, which seems like a batch job.
   
   IcebergFilesCommitter -> IcebergCommitter. Iceberg only commits files. So including Files seems redundant.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org