You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/26 05:04:38 UTC

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4570: [WIP][Inventory Design Change] Remove endpoint register and endpoint inventory

kezhenxu94 commented on a change in pull request #4570: [WIP][Inventory Design Change] Remove endpoint register and endpoint inventory
URL: https://github.com/apache/skywalking/pull/4570#discussion_r398319719
 
 

 ##########
 File path: oap-server/server-storage-plugin/storage-jdbc-hikaricp-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/mysql/MySQLTableInstaller.java
 ##########
 @@ -111,7 +111,7 @@ protected void createIndexes(JDBCHikariCPClient client, Model model) throws Stor
             case SERVICE_INVENTORY:
             case SERVICE_INSTANCE_INVENTORY:
             case NETWORK_ADDRESS:
-            case ENDPOINT_INVENTORY:
+            case ENDPOINT_TRAFFIC:
                 createInventoryIndexes(client, model);
 
 Review comment:
   `EndpointTraffic` is not `RegisterSource` type, but creating `InventoryIndexes` needs a `sequence` column, which is defined in `RegisterSource`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services