You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@stanbol.apache.org by rw...@apache.org on 2014/03/04 09:43:46 UTC

svn commit: r1573936 - /stanbol/branches/release-0.12/enhancement-engines/lucenefstlinking/src/main/java/org/apache/stanbol/enhancer/engines/lucenefstlinking/FstLinkingEngine.java

Author: rwesten
Date: Tue Mar  4 08:43:46 2014
New Revision: 1573936

URL: http://svn.apache.org/r1573936
Log:
fixes an other bug introduced by STANBOL-1283: Entity score based rankings are now calculated before cutting of the list of suggestions at index maxSuggestions

Modified:
    stanbol/branches/release-0.12/enhancement-engines/lucenefstlinking/src/main/java/org/apache/stanbol/enhancer/engines/lucenefstlinking/FstLinkingEngine.java

Modified: stanbol/branches/release-0.12/enhancement-engines/lucenefstlinking/src/main/java/org/apache/stanbol/enhancer/engines/lucenefstlinking/FstLinkingEngine.java
URL: http://svn.apache.org/viewvc/stanbol/branches/release-0.12/enhancement-engines/lucenefstlinking/src/main/java/org/apache/stanbol/enhancer/engines/lucenefstlinking/FstLinkingEngine.java?rev=1573936&r1=1573935&r2=1573936&view=diff
==============================================================================
--- stanbol/branches/release-0.12/enhancement-engines/lucenefstlinking/src/main/java/org/apache/stanbol/enhancer/engines/lucenefstlinking/FstLinkingEngine.java (original)
+++ stanbol/branches/release-0.12/enhancement-engines/lucenefstlinking/src/main/java/org/apache/stanbol/enhancer/engines/lucenefstlinking/FstLinkingEngine.java Tue Mar  4 08:43:46 2014
@@ -307,22 +307,23 @@ public class FstLinkingEngine implements
                     } while(numInclude < suggestions.size() && actScore >= minIncludeScore);
                     maxSuggestions = numInclude - 1;
                 }
-                //remove all suggestions > maxSuggestions
-                if(suggestions.size() > maxSuggestions){
-                    suggestions.subList(maxSuggestions,suggestions.size()).clear();
-                }
                 //adapt score based on entity ranking
                 if(elConfig.isRankEqualScoresBasedOnEntityRankings()){
                     adaptScoresForEntityRankings(suggestions);
                 }
-            }
-            if(log.isTraceEnabled()){ //log the suggestion information
-                log.trace("Suggestions:");
-                int si=1;
-                for(Match m : suggestions){
-                    log.trace(" {}. {} - {} ({})", new Object[]{
-                            si,m.getScore(),m.getMatchLabel(),m.getUri()});
-                    si++;
+                if(log.isTraceEnabled()){ //log the suggestion information
+                    log.trace("Suggestions:");
+                    int si=1;
+                    for(Match m : suggestions){
+                        log.trace(" {}. {} - {} ({})", new Object[]{
+                                si <= maxSuggestions ? si : "--",
+                                m.getScore(),m.getMatchLabel(),m.getUri()});
+                        si++;
+                    }
+                }
+                //remove all suggestions > maxSuggestions
+                if(suggestions.size() > maxSuggestions){
+                    suggestions.subList(maxSuggestions,suggestions.size()).clear();
                 }
             }
             tag.setSuggestions(suggestions);