You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@samza.apache.org by Xinyu Liu <xi...@gmail.com> on 2017/10/24 22:54:24 UTC

Review Request 63267: Add instructions to README.md

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63267/
-----------------------------------------------------------

Review request for samza and Prateek Maheshwari.


Repository: samza-hello-samza


Description
-------

Add instructions to README.md


Diffs
-----

  README.md 0f80e9e52240abc071dcdfb56800826ef5d49d7d 
  build.gradle ec451d576a157eba2d8889b63b8574f397937197 


Diff: https://reviews.apache.org/r/63267/diff/1/


Testing
-------


Thanks,

Xinyu Liu

Re: Review Request 63267: Add instructions to README.md

Posted by Prateek Maheshwari via Review Board <no...@reviews.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63267/#review189259
-----------------------------------------------------------


Ship it!




Thanks for adding this. Let's commit to whichever branch this was tested on, and I'll copy and update for the other branch.

- Prateek Maheshwari


On Oct. 24, 2017, 3:54 p.m., Xinyu Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63267/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2017, 3:54 p.m.)
> 
> 
> Review request for samza and Prateek Maheshwari.
> 
> 
> Repository: samza-hello-samza
> 
> 
> Description
> -------
> 
> Add instructions to README.md
> 
> 
> Diffs
> -----
> 
>   README.md 0f80e9e52240abc071dcdfb56800826ef5d49d7d 
>   build.gradle ec451d576a157eba2d8889b63b8574f397937197 
> 
> 
> Diff: https://reviews.apache.org/r/63267/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Xinyu Liu
> 
>

Re: Review Request 63267: Add instructions to README.md

Posted by Prateek Maheshwari via Review Board <no...@reviews.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63267/#review189258
-----------------------------------------------------------


Ship it!




Thanks for adding this. Were these instructions were tested on the latest branch or on master? Let's commit to whichever it was, and I'll copy it over and update for the other branch.

- Prateek Maheshwari


On Oct. 24, 2017, 3:54 p.m., Xinyu Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63267/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2017, 3:54 p.m.)
> 
> 
> Review request for samza and Prateek Maheshwari.
> 
> 
> Repository: samza-hello-samza
> 
> 
> Description
> -------
> 
> Add instructions to README.md
> 
> 
> Diffs
> -----
> 
>   README.md 0f80e9e52240abc071dcdfb56800826ef5d49d7d 
>   build.gradle ec451d576a157eba2d8889b63b8574f397937197 
> 
> 
> Diff: https://reviews.apache.org/r/63267/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Xinyu Liu
> 
>