You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "SML0127 (via GitHub)" <gi...@apache.org> on 2024/09/05 03:47:35 UTC
Re: [PR] Flink - Fix incorrect / old row being written into delta files when using upsert mode [iceberg]
SML0127 commented on code in PR #4364:
URL: https://github.com/apache/iceberg/pull/4364#discussion_r1744762446
##########
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/sink/BaseDeltaTaskWriter.java:
##########
@@ -74,7 +80,7 @@ public void write(RowData row) throws IOException {
case INSERT:
case UPDATE_AFTER:
if (upsert) {
- writer.delete(row);
+ writer.deleteKey(deleteSchemaProjection.wrap(row));
Review Comment:
@rdblue @kbendick
sorry to mentions for old pr.
I wonder how to distinguish whether equality field in equality delete file was append by `DELETE` or `INSERT / UPDATE_AFTER` when scan iceberg table.
##########
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/sink/BaseDeltaTaskWriter.java:
##########
@@ -74,7 +80,7 @@ public void write(RowData row) throws IOException {
case INSERT:
case UPDATE_AFTER:
if (upsert) {
- writer.delete(row);
+ writer.deleteKey(deleteSchemaProjection.wrap(row));
Review Comment:
@rdblue @kbendick
sorry to mention for old pr.
I wonder how to distinguish whether equality field in equality delete file was append by `DELETE` or `INSERT / UPDATE_AFTER` when scan iceberg table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org