[GitHub] [iceberg] RussellSpitzer commented on a diff in pull request #4847: Core: Add reference_snapshot_id column and filter to AllManifest table

[GitBox <gi...@apache.org>]

RussellSpitzer commented on code in PR #4847:
URL: https://github.com/apache/iceberg/pull/4847#discussion_r906391975


##########
core/src/main/java/org/apache/iceberg/AllManifestsTable.java:
##########
@@ -43,6 +52,7 @@
  * This table may return duplicate rows.
  */
 public class AllManifestsTable extends BaseMetadataTable {
+  private static final int REF_SNAPSHOT_ID = 18;

Review Comment:
   Are we keeping this a constant because we refer to it again in the isSnapshotRef function? I just wonder because we don't do this for any of our other fields in the schema.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org