You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "zeroshade (via GitHub)" <gi...@apache.org> on 2024/01/29 20:53:28 UTC
[PR] feat(go/adbc/driver/flightsql): propagate cookies to sub-clients [arrow-adbc]
zeroshade opened a new pull request, #1497:
URL: https://github.com/apache/arrow-adbc/pull/1497
Closes #1194
This also bumps our dependency up to arrow v16
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(go/adbc/driver/flightsql): propagate cookies to sub-clients [arrow-adbc]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on code in PR #1497:
URL: https://github.com/apache/arrow-adbc/pull/1497#discussion_r1471718167
##########
go/adbc/driver/flightsql/flightsql_adbc_server_test.go:
##########
@@ -1173,9 +1181,11 @@ type CookieTests struct {
}
func (suite *CookieTests) SetupSuite() {
- suite.DoSetupSuite(&CookieTestServer{}, nil, map[string]string{
+ ts := &CookieTestServer{}
+ suite.DoSetupSuite(ts, nil, map[string]string{
driver.OptionCookieMiddleware: adbc.OptionValueEnabled,
})
+ ts.addr = "grpc://" + suite.s.Addr().String()
}
func (suite *CookieTests) TestCookieUsage() {
Review Comment:
The modification i made to the test https://github.com/apache/arrow-adbc/pull/1497/files#diff-fff4d523df1762b32c2cd86dbe03bd2ec80fe856fc91471f24604909486824efL1098 does this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(go/adbc/driver/flightsql): propagate cookies to sub-clients [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #1497:
URL: https://github.com/apache/arrow-adbc/pull/1497
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(go/adbc/driver/flightsql): propagate cookies to sub-clients [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #1497:
URL: https://github.com/apache/arrow-adbc/pull/1497#discussion_r1471724036
##########
go/adbc/driver/flightsql/flightsql_adbc_server_test.go:
##########
@@ -1173,9 +1181,11 @@ type CookieTests struct {
}
func (suite *CookieTests) SetupSuite() {
- suite.DoSetupSuite(&CookieTestServer{}, nil, map[string]string{
+ ts := &CookieTestServer{}
+ suite.DoSetupSuite(ts, nil, map[string]string{
driver.OptionCookieMiddleware: adbc.OptionValueEnabled,
})
+ ts.addr = "grpc://" + suite.s.Addr().String()
}
func (suite *CookieTests) TestCookieUsage() {
Review Comment:
Hmm, the client cache isn't shared between metadata/data? Looks like not. That may be something we want to fix in the future so this test may be a little unstable in that case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(go/adbc/driver/flightsql): propagate cookies to sub-clients [arrow-adbc]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on PR #1497:
URL: https://github.com/apache/arrow-adbc/pull/1497#issuecomment-1915688418
Thanks for the R changes...before 0.10.0 / Arrow 16 I will try to update arrow/go so that `go mod vendor` doesn't skip those file!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(go/adbc/driver/flightsql): propagate cookies to sub-clients [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #1497:
URL: https://github.com/apache/arrow-adbc/pull/1497#discussion_r1471209952
##########
go/adbc/driver/flightsql/flightsql_adbc_server_test.go:
##########
@@ -1173,9 +1181,11 @@ type CookieTests struct {
}
func (suite *CookieTests) SetupSuite() {
- suite.DoSetupSuite(&CookieTestServer{}, nil, map[string]string{
+ ts := &CookieTestServer{}
+ suite.DoSetupSuite(ts, nil, map[string]string{
driver.OptionCookieMiddleware: adbc.OptionValueEnabled,
})
+ ts.addr = "grpc://" + suite.s.Addr().String()
}
func (suite *CookieTests) TestCookieUsage() {
Review Comment:
Can we add a specific test to make sure the token/cookies are copied?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org