[jira] [Commented] (FLINK-8178) Introduce not threadsafe write only BufferBuilder

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316363#comment-16316363 ] 

ASF GitHub Bot commented on FLINK-8178:
---------------------------------------

Github user NicoK commented on the issue:

    https://github.com/apache/flink/pull/5105
  
    merged in c6945c2ef48d4c2cad3fc935435c1ab83e834969
    @pnowojski can you close this PR?


> Introduce not threadsafe write only BufferBuilder
> -------------------------------------------------
>
>                 Key: FLINK-8178
>                 URL: https://issues.apache.org/jira/browse/FLINK-8178
>             Project: Flink
>          Issue Type: Improvement
>          Components: Network
>            Reporter: Piotr Nowojski
>            Assignee: Piotr Nowojski
>             Fix For: 1.5.0
>
>
> While Buffer class is used in multithreaded context it requires synchronisation. Now it is miss-leading/unclear and suggesting that RecordSerializer should take into account synchronisation of the Buffer that's holding. With NotThreadSafe BufferBuilder there would be clear separation between single-threaded writing/creating a BufferBuilder and multithreaded Buffer handling/retaining/recycling.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)