You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/04/15 22:21:35 UTC
[GitHub] [hive] omalley opened a new pull request #983: HIVE-23215. Make
FilterContext an interface.
omalley opened a new pull request #983: HIVE-23215. Make FilterContext an interface.
URL: https://github.com/apache/hive/pull/983
Here's a first pass at keeping a single copy of the selected data.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] omalley commented on a change in pull request #983:
HIVE-23215. Make FilterContext an interface.
Posted by GitBox <gi...@apache.org>.
omalley commented on a change in pull request #983: HIVE-23215. Make FilterContext an interface.
URL: https://github.com/apache/hive/pull/983#discussion_r409648595
##########
File path: storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatch.java
##########
@@ -338,6 +339,7 @@ public void write(DataOutput arg0) throws IOException {
* - resets each column
* - inits each column
*/
+ @Override
public void reset() {
Review comment:
My problem is that VectorizedRowBatch currently has an implicit invariant that selected is never null. Changing that assumption seems potentially problematic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pgaref commented on a change in pull request #983:
HIVE-23215. Make FilterContext an interface.
Posted by GitBox <gi...@apache.org>.
pgaref commented on a change in pull request #983: HIVE-23215. Make FilterContext an interface.
URL: https://github.com/apache/hive/pull/983#discussion_r409416250
##########
File path: storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatch.java
##########
@@ -359,4 +361,62 @@ public void ensureSize(int rows) {
cols[i].ensureSize(rows, false);
}
Review comment:
Should we call updateSelected(rows) here as well?
According to getMaxSize() method, selected array should be able to hold the max number of rows.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] omalley commented on a change in pull request #983:
HIVE-23215. Make FilterContext an interface.
Posted by GitBox <gi...@apache.org>.
omalley commented on a change in pull request #983: HIVE-23215. Make FilterContext an interface.
URL: https://github.com/apache/hive/pull/983#discussion_r409651334
##########
File path: storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatch.java
##########
@@ -359,4 +361,62 @@ public void ensureSize(int rows) {
cols[i].ensureSize(rows, false);
}
Review comment:
Yeah, that is a good idea.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pgaref commented on issue #983: HIVE-23215. Make
FilterContext an interface.
Posted by GitBox <gi...@apache.org>.
pgaref commented on issue #983: HIVE-23215. Make FilterContext an interface.
URL: https://github.com/apache/hive/pull/983#issuecomment-614534657
Thanks for the patch @omalley ! LGTM overall left some comments
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pgaref commented on a change in pull request #983:
HIVE-23215. Make FilterContext an interface.
Posted by GitBox <gi...@apache.org>.
pgaref commented on a change in pull request #983: HIVE-23215. Make FilterContext an interface.
URL: https://github.com/apache/hive/pull/983#discussion_r409417244
##########
File path: storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatch.java
##########
@@ -338,6 +339,7 @@ public void write(DataOutput arg0) throws IOException {
* - resets each column
* - inits each column
*/
+ @Override
public void reset() {
Review comment:
Would it make sense to also set the selected array to null here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pgaref commented on a change in pull request #983:
HIVE-23215. Make FilterContext an interface.
Posted by GitBox <gi...@apache.org>.
pgaref commented on a change in pull request #983: HIVE-23215. Make FilterContext an interface.
URL: https://github.com/apache/hive/pull/983#discussion_r409417244
##########
File path: storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatch.java
##########
@@ -338,6 +339,7 @@ public void write(DataOutput arg0) throws IOException {
* - resets each column
* - inits each column
*/
+ @Override
public void reset() {
Review comment:
Can we also set the selected array to null here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org