You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/01 18:22:01 UTC
[GitHub] [arrow] mqy opened a new pull request #9072: ARROW-11101: [Rust] rewrite pre-commit hook
mqy opened a new pull request #9072:
URL: https://github.com/apache/arrow/pull/9072
Currently, the client side git pre-commit hook checks and runs `cargo fmt` with stable version, but the CI check may fail in nightly version occasionally even if the code has been formatted with stable.
It seems that, this problem can be resolved by: running `cargo +nighty fmt` before `cargo +stable fmt`. Thus `pre-commit.sh` should be updated in this way.
In this PR:
1. only check staged *.rs files and exit if no changes
2. cargo clippy is moved before cargo fmt
3. run `cargo +nighty fmt` before cargo +stable fmt
4. show more concise tip messages
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #9072: ARROW-11101: [Rust] rewrite pre-commit hook
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9072:
URL: https://github.com/apache/arrow/pull/9072#issuecomment-753362004
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9072?src=pr&el=h1) Report
> Merging [#9072](https://codecov.io/gh/apache/arrow/pull/9072?src=pr&el=desc) (552bb06) into [master](https://codecov.io/gh/apache/arrow/commit/cc0ee5efcf9f6a67bcc407a11e8553a0409275c1?el=desc) (cc0ee5e) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/arrow/pull/9072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9072 +/- ##
=======================================
Coverage 82.55% 82.55%
=======================================
Files 203 203
Lines 50043 50043
=======================================
+ Hits 41313 41315 +2
+ Misses 8730 8728 -2
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/parquet/src/arrow/schema.rs](https://codecov.io/gh/apache/arrow/pull/9072/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9hcnJvdy9zY2hlbWEucnM=) | `90.93% <0.00%> (+0.31%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9072?src=pr&el=footer). Last update [cc0ee5e...552bb06](https://codecov.io/gh/apache/arrow/pull/9072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9072: ARROW-11101: [Rust] rewrite pre-commit hook
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9072:
URL: https://github.com/apache/arrow/pull/9072#issuecomment-753369397
https://issues.apache.org/jira/browse/ARROW-11101
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb closed pull request #9072: ARROW-11101: [Rust] rewrite pre-commit hook
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #9072:
URL: https://github.com/apache/arrow/pull/9072
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org